From patchwork Wed Feb 10 21:01:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 71412 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1l9wdP-003Qpp-PI; Wed, 10 Feb 2021 21:02:52 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbhBJVCe (ORCPT + 1 other); Wed, 10 Feb 2021 16:02:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:51498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbhBJVCd (ORCPT ); Wed, 10 Feb 2021 16:02:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8860064ED0; Wed, 10 Feb 2021 21:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612990912; bh=yTX2pW8uQGXiirQGlQTPqGLyF37JnySPC1tXe+4P2lQ=; h=Date:From:To:Cc:Subject:From; b=VC131B77LJ8tPnT3qZlg9vAit8wRwB7hbTJBvgRvL29ugUt4sSm05NTEypw4IzL2C wG2EJsk9Lj35n+TczZJWoDzSKw14ibew2/w2KJ7Zq2spJ4sjroo/esjA+/6N1k7GFT eLcy1xJlK0dchyUZne4csQYfIcdtgfyHBdmnoy1v0ZYFT6mi7aOB410zSnTadd6GFL iXLJtz2eT0oT5M9m00MaWXVspCNuDuYaA+293PSthpnBGQ12JEowarTvSICYdsXbXF xUvynz/xlM4WE5uKGPpuLlSS+7TSRogs9j4qRA1vREIGicL/OOtKQZ7iWQzb6HxHIE JkXbyXazylJKg== Date: Wed, 10 Feb 2021 15:01:49 -0600 From: "Gustavo A. R. Silva" To: Laurent Pinchart , Mauro Carvalho Chehab , Ricardo Ribalda , Tomasz Figa Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH v2][next] media: uvcvideo: Remove duplicate assignments to pointer dma_dev Message-ID: <20210210210149.GA842694@embeddedor> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -3.1 (---) X-LSpam-Report: No, score=-3.1 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Remove redundant assignments to pointer dma_dev. Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API") Addresses-Coverity-ID: 1501703 ("Evaluation order violation") Addresses-Coverity-ID: 1501692 ("Evaluation order violation") Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Remove another redundant assignment in function uvc_free_urb_buffers(). drivers/media/usb/uvc/uvc_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index dc81f9a86eca..6f2f308d86fe 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device) { - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream); + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream); if (for_device) { dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt, @@ -1586,7 +1586,7 @@ static void uvc_video_complete(struct urb *urb) */ static void uvc_free_urb_buffers(struct uvc_streaming *stream) { - struct device *dma_dev = dma_dev = stream_to_dmadev(stream); + struct device *dma_dev = stream_to_dmadev(stream); struct uvc_urb *uvc_urb; for_each_uvc_urb(uvc_urb, stream) {