From patchwork Wed Feb 10 17:45:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 71408 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1l9tbQ-003F01-RC; Wed, 10 Feb 2021 17:48:37 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233201AbhBJRsP (ORCPT + 1 other); Wed, 10 Feb 2021 12:48:15 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:51186 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233230AbhBJRra (ORCPT ); Wed, 10 Feb 2021 12:47:30 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l9tYp-0002MG-H3; Wed, 10 Feb 2021 17:46:41 +0000 From: Colin King To: Laurent Pinchart , Mauro Carvalho Chehab , Ricardo Ribalda , Tomasz Figa , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] media: uvcvideo: remove duplicated dma_dev assignment Date: Wed, 10 Feb 2021 17:45:55 +0000 Message-Id: <20210210174555.144128-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: Colin Ian King The assignment to dma_dev has been performed twice in one statement. Fix this by removing the extraneous assignment. Addresses-Coverity: ("Evaluation order violation") Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API") Signed-off-by: Colin Ian King --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index dc81f9a86eca..edf451a956d8 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device) { - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream); + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream); if (for_device) { dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt,