From patchwork Thu Jan 28 13:10:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 71174 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1l5761-000DKF-BS; Thu, 28 Jan 2021 13:12:25 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbhA1NLu (ORCPT + 1 other); Thu, 28 Jan 2021 08:11:50 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:39718 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231797AbhA1NLj (ORCPT ); Thu, 28 Jan 2021 08:11:39 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l574Y-00053e-CY; Thu, 28 Jan 2021 13:10:54 +0000 From: Colin King To: Laurent Pinchart , Mauro Carvalho Chehab , Ricardo Ribalda , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] media: uvcvideo: Fix memory leak when gpiod_to_irq fails Date: Thu, 28 Jan 2021 13:10:54 +0000 Message-Id: <20210128131054.637715-1-colin.king@canonical.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: Colin Ian King Currently when the call to gpiod_to_irq fails the error return path does not kfree the recently allocated object 'unit'. Fix this by kfree'ing it before returning. Addresses-Coverity: ("Resource leak") Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT") Signed-off-by: Colin Ian King --- drivers/media/usb/uvc/uvc_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 1abc122a0977..56f867790ef1 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -1543,6 +1543,7 @@ static int uvc_gpio_parse(struct uvc_device *dev) if (irq != EPROBE_DEFER) dev_err(&dev->udev->dev, "No IRQ for privacy GPIO (%d)\n", irq); + kfree(unit); return irq; }