From patchwork Fri Mar 1 09:38:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 54777 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzef8-0002yM-6G; Fri, 01 Mar 2019 09:41:02 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387626AbfCAJk7 (ORCPT + 1 other); Fri, 1 Mar 2019 04:40:59 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:45846 "EHLO albert.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732784AbfCAJk5 (ORCPT ); Fri, 1 Mar 2019 04:40:57 -0500 Received: from ramsan ([84.194.111.163]) by albert.telenet-ops.be with bizsmtp id iZgv1z00M3XaVaC06Zgvf7; Fri, 01 Mar 2019 10:40:56 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1gzef1-0005Ll-In; Fri, 01 Mar 2019 10:40:55 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1gzeci-0002tr-EK; Fri, 01 Mar 2019 10:38:32 +0100 From: Geert Uytterhoeven To: Mauro Carvalho Chehab , Ramesh Shanmugasundaram Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing Date: Fri, 1 Mar 2019 10:38:31 +0100 Message-Id: <20190301093831.11106-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org devm_ioremap_resource() already prints an error message on failure, so there is no need to repeat that. Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund Reviewed-by: Simon Horman --- v2: - Drop assignment to ret. --- drivers/media/platform/rcar_drif.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c index c417ff8f6fe548f3..608e5217ccd50a1b 100644 --- a/drivers/media/platform/rcar_drif.c +++ b/drivers/media/platform/rcar_drif.c @@ -1405,11 +1405,9 @@ static int rcar_drif_probe(struct platform_device *pdev) /* Register map */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ch->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(ch->base)) { - ret = PTR_ERR(ch->base); - dev_err(&pdev->dev, "ioremap failed (%d)\n", ret); - return ret; - } + if (IS_ERR(ch->base)) + return PTR_ERR(ch->base); + ch->start = res->start; platform_set_drvdata(pdev, ch);