From patchwork Mon Feb 5 20:10:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 46850 Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ein7G-0001IM-RA; Mon, 05 Feb 2018 20:11:51 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbeBEULP (ORCPT + 1 other); Mon, 5 Feb 2018 15:11:15 -0500 Received: from sauhun.de ([88.99.104.3]:34240 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeBEUK0 (ORCPT ); Mon, 5 Feb 2018 15:10:26 -0500 Received: from localhost (p54B337CF.dip0.t-ipconnect.de [84.179.55.207]) by pokefinder.org (Postfix) with ESMTPSA id A87572C3257; Mon, 5 Feb 2018 21:10:24 +0100 (CET) From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Dan Carpenter , linux-renesas-soc@vger.kernel.org, Wolfram Sang , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 3/4] v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing with a mask Date: Mon, 5 Feb 2018 21:10:00 +0100 Message-Id: <20180205201002.23621-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> References: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Signed-off-by: Wolfram Sang --- Only build tested. To be applied individually per subsystem. drivers/media/dvb-frontends/stb0899_reg.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/stb0899_reg.h b/drivers/media/dvb-frontends/stb0899_reg.h index ba1ed56304a0f4..f564269249a682 100644 --- a/drivers/media/dvb-frontends/stb0899_reg.h +++ b/drivers/media/dvb-frontends/stb0899_reg.h @@ -374,22 +374,22 @@ #define STB0899_OFF0_IF_AGC_GAIN 0xf30c #define STB0899_BASE_IF_AGC_GAIN 0x00000000 -#define STB0899_IF_AGC_GAIN (0x3fff < 0) +#define STB0899_IF_AGC_GAIN (0x3fff << 0) #define STB0899_OFFST_IF_AGC_GAIN 0 #define STB0899_WIDTH_IF_AGC_GAIN 14 #define STB0899_OFF0_BB_AGC_GAIN 0xf310 #define STB0899_BASE_BB_AGC_GAIN 0x00000000 -#define STB0899_BB_AGC_GAIN (0x3fff < 0) +#define STB0899_BB_AGC_GAIN (0x3fff << 0) #define STB0899_OFFST_BB_AGC_GAIN 0 #define STB0899_WIDTH_BB_AGC_GAIN 14 #define STB0899_OFF0_DC_OFFSET 0xf314 #define STB0899_BASE_DC_OFFSET 0x00000000 -#define STB0899_I (0xff < 8) +#define STB0899_I (0xff << 8) #define STB0899_OFFST_I 8 #define STB0899_WIDTH_I 8 -#define STB0899_Q (0xff < 0) +#define STB0899_Q (0xff << 0) #define STB0899_OFFST_Q 8 #define STB0899_WIDTH_Q 8