From patchwork Thu Jul 13 11:12:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 42460 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVc33-0008Ob-Le; Thu, 13 Jul 2017 11:12:45 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-5) with esmtp id 1dVc31-0008Nf-8Q; Thu, 13 Jul 2017 13:12:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbdGMLM1 (ORCPT + 1 other); Thu, 13 Jul 2017 07:12:27 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49351 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdGMLM0 (ORCPT ); Thu, 13 Jul 2017 07:12:26 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id EE44482413; Thu, 13 Jul 2017 13:12:24 +0200 (CEST) Date: Thu, 13 Jul 2017 13:12:24 +0200 From: Pavel Machek To: Sakari Ailus Cc: Sebastian Reichel , Sakari Ailus , linux-media@vger.kernel.org Subject: Re: [PATCH 7/8] omap3isp: Check for valid port in endpoints Message-ID: <20170713111224.GG1363@amd> References: <20170705230019.5461-1-sakari.ailus@linux.intel.com> <20170705230019.5461-8-sakari.ailus@linux.intel.com> <20170706111149.ws6olipu7ph4tcyd@earth> <20170707130432.g4di5a3he2bf5baw@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170707130432.g4di5a3he2bf5baw@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.7.13.110616 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FROM_DOMAIN_IN_ANY_CC1 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' Hi! > > On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote: > > > Check that we do have a valid port in an endpoint, return an error if not. > > > > > > Signed-off-by: Sakari Ailus > > > > Reviewed-by: Sebastian Reichel > > Thanks for the reviews, Sebastian and Pavel! > > I'll send a pull request on these for 4.14 once we have -rc1 in the media > tree. I can update my patches when updated ccp2 branch is ready. And actually, I'd quite like to get rest of support ready for 4.14, too. I believe we are close enough. I re-checked, and it seems to work w/o the "smiapp-pll: Take existing divisor into account in minimum divisor check" patch; so with "omap3isp: add CSI1 support" plus the other ccp2 patches, plus dts changes, we should be ok. Best regards, Pavel commit eba2751794239780efb256ce7079294a4d4c6e74 Author: Pavel Date: Mon Feb 13 21:18:27 2017 +0100 From: Sakari Ailus Required added multiplier (and divisor) calculation did not take into account the existing divisor when checking the values against the minimum divisor. Do just that. Signed-off-by: Sakari Ailus Signed-off-by: Ivaylo Dimitrov Signed-off-by: Pavel Machek diff --git a/drivers/media/i2c/smiapp-pll.c b/drivers/media/i2c/smiapp-pll.c index 771db56..0ada972 100644 --- a/drivers/media/i2c/smiapp-pll.c +++ b/drivers/media/i2c/smiapp-pll.c @@ -227,7 +227,8 @@ static int __smiapp_pll_calculate( more_mul_factor = lcm(div, pll->pre_pll_clk_div) / div; dev_dbg(dev, "more_mul_factor: %u\n", more_mul_factor); - more_mul_factor = lcm(more_mul_factor, op_limits->min_sys_clk_div); + more_mul_factor = lcm(more_mul_factor, + DIV_ROUND_UP(op_limits->min_sys_clk_div, div)); dev_dbg(dev, "more_mul_factor: min_op_sys_clk_div: %d\n", more_mul_factor); i = roundup(more_mul_min, more_mul_factor);