From patchwork Thu Jun 1 07:46:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 41571 X-Patchwork-Delegate: sean@mess.org Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGKoE-0002Ut-8j; Thu, 01 Jun 2017 07:46:18 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-8) with esmtp id 1dGKoC-0006oF-kD; Thu, 01 Jun 2017 09:46:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbdFAHqN (ORCPT + 1 other); Thu, 1 Jun 2017 03:46:13 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34898 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdFAHqK (ORCPT ); Thu, 1 Jun 2017 03:46:10 -0400 Received: by mail-lf0-f65.google.com with SMTP id 99so3278879lfu.2; Thu, 01 Jun 2017 00:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1ew2FPzN6adONUUt4nYavyZtA1+X+Vcd6dQhCwKb9Oc=; b=GVrU/8VdPIboKafecrOIrkE+pIQ+6jJt3tgLMtAP7hCCsR+bUJCvyYEDwwjiPX6AT1 L64SL9vbo/a9mnu0of1nVyHne6v/WMFzR9qV5yXwN/7iHv+BrxSMUI0vvXIGAakaIBGR pEh6Qbqcm1phL80VOEavHL+zUqyyh+CdlqJfsBbt30xiJUiRoihmJDU4R1PaYQPSyuVp hpmQUf92usF2HrAe01cV7OFRIf2jmpQXYr3ywOhdCUdCuYH3/U41G/RdPJcqEslvnCWi gZOxXd7r/7FGZlxSa4JQ8c00CTT1m0h6oVOiCiOhAPnkEmdhEMml+Id0L3bzMzNGUW5/ jVcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=1ew2FPzN6adONUUt4nYavyZtA1+X+Vcd6dQhCwKb9Oc=; b=gc20e6WCSAay9PFfo39wNLna5DwOzGiZU3zJyBtdHUw6koJH10EA+rQe3pUVBm9YN2 YIF1hudDxEc1QCtzwFZddayHmaUerZgVBAqo7Z+wOzbjQD51XYQkBIjAhwxgZNUomeub /OCcEVZj0bASMytnA16POzS1b4BtYmScQoSWPwm6Q2vlK5k9k5jHHfHO0uK6maalPVZ1 moTxy0qKpSAcL1pp2ktoVrJq8Oj+SKUi2cP5xWO0xrdAdjjf+RcvNp0NJbhqgPbRo/Kr e7ABtPVXt5TBs2UYVFjPZk0naK12Bk+GdQDH6mgWP9DkQRCaQf423T2kRVq9hsSgfVSd S7Vg== X-Gm-Message-State: AODbwcBqEHHsmn9WYbdZdXMvAXj8NpTodcZbVLVGkDX1BpDkGy5erqrF msNBKegNi8FkC4p3xZQ= X-Received: by 10.46.14.1 with SMTP id 1mr68044ljo.40.1496303168794; Thu, 01 Jun 2017 00:46:08 -0700 (PDT) Received: from xi.terra (c-42c8e255.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.226.200.66]) by smtp.gmail.com with ESMTPSA id m73sm4156218lfg.49.2017.06.01.00.46.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2017 00:46:07 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.89) (envelope-from ) id 1dGKo9-0005MA-JV; Thu, 01 Jun 2017 09:46:13 +0200 From: Johan Hovold To: Mauro Carvalho Chehab Cc: Sean Young , linux-media@vger.kernel.org, linux-usb@vger.kernel.org, Johan Hovold Subject: [PATCH 2/2] [media] mceusb: drop redundant urb reinitialisation Date: Thu, 1 Jun 2017 09:46:00 +0200 Message-Id: <20170601074600.20548-2-johan@kernel.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170601074600.20548-1-johan@kernel.org> References: <20170601074600.20548-1-johan@kernel.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.6.1.73618 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_800_899 0, DKIM_SIGNATURE 0, FROM_SAME_AS_TO_DOMAIN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Drop a since commit e1159cb35712 ("[media] mceusb: remove pointless mce_flush_rx_buffer function") redundant reinitialisation of two urb fields immediately after they have been initialised. Signed-off-by: Johan Hovold --- drivers/media/rc/mceusb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 0a16bd34ee4e..cba7ae90c000 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -760,9 +760,6 @@ static void mce_request_packet(struct mceusb_dev *ir, unsigned char *data, dev_dbg(dev, "receive request called (size=%#x)", size); - async_urb->transfer_buffer_length = size; - async_urb->dev = ir->usbdev; - res = usb_submit_urb(async_urb, GFP_ATOMIC); if (res) { dev_err(dev, "receive request FAILED! (res=%d)", res);