From patchwork Tue May 30 09:53:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 41543 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFdr3-00087k-NC; Tue, 30 May 2017 09:54:21 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-7) with esmtp id 1dFdr1-0004LK-1Y; Tue, 30 May 2017 11:54:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdE3JyG (ORCPT + 1 other); Tue, 30 May 2017 05:54:06 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35405 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbdE3JyF (ORCPT ); Tue, 30 May 2017 05:54:05 -0400 Received: by mail-pf0-f170.google.com with SMTP id n23so67849164pfb.2 for ; Tue, 30 May 2017 02:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=kN9X7OkdJtjY4cUxSG3RPdOE98OJmb/I7FvDwd21p0Y=; b=VkmXZ2gnc3F3cfD6CfFqSMdxhSXtl6W/mmZMvReTQFovqrzmSaoywqf+1xUXnbtLhL +TfyXQVCZD+nePlmTDsnzIRcxhZRmdcNbmh2yFoeO5dpwiVvf6GzTYgSBTCK7Mi+NUq8 QmAoANThuQL9nFExWj5Rb+ky4EPfNY9cC8XJM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kN9X7OkdJtjY4cUxSG3RPdOE98OJmb/I7FvDwd21p0Y=; b=QOyB3unVL4w5T6QNL/R2eEaakUIwbt45Jvw+YR0L+ulP2M2XmB69yGXVOh7zflyvSI h/lGGzq4ma3d5U/azrxSZyQEPldzQn0MbubYvJnkb/NWpFPsBQeVYkqqLUUaDTsIrTGc DzbvDwd5c0KS+UHa+2zr689RAb0k5TYsipT06anS8waW4vGJbFPJlgts81sl5pU7dcrW Sm66i4AP6twO04UYwdP7TFXqb1u7PCy4KsODs2uHrxc6tdI4+wZ6bBknCE0utojY0gKv sQXXHPiyR2EqKqdM8cq/pyW1HTLeUCo1NJqIiuo7DpDfghl6DedoqnU6q33jurBGqExG Jh+g== X-Gm-Message-State: AODbwcD+oFKSP2hrFaE/mUV2s+V3CQT+5OQY/0AShBdSafchg6J9PtId C+E9uxrJ93aOVeir X-Received: by 10.84.254.2 with SMTP id b2mr81791740plm.185.1496138045091; Tue, 30 May 2017 02:54:05 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([100.103.2.121]) by smtp.gmail.com with ESMTPSA id c12sm22481282pfl.79.2017.05.30.02.54.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 May 2017 02:54:04 -0700 (PDT) From: Hirokazu Honda To: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hirokazu Honda Subject: [PATCH v2] [media] mtk-vcodec: Show mtk driver error without DEBUG definition Date: Tue, 30 May 2017 18:53:58 +0900 Message-Id: <20170530095358.2685-1-hiroh@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.5.30.94517 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, LEGITIMATE_SIGNS 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' A driver error message is shown without DEBUG definition to find an error and debug easily. Signed-off-by: Hirokazu Honda Acked-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h index 237e144c194f..06c254f5c171 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h @@ -32,6 +32,15 @@ extern int mtk_v4l2_dbg_level; extern bool mtk_vcodec_dbg; +#define mtk_v4l2_err(fmt, args...) \ + pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ + ##args) + +#define mtk_vcodec_err(h, fmt, args...) \ + pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ + ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) + + #if defined(DEBUG) #define mtk_v4l2_debug(level, fmt, args...) \ @@ -41,11 +50,6 @@ extern bool mtk_vcodec_dbg; level, __func__, __LINE__, ##args); \ } while (0) -#define mtk_v4l2_err(fmt, args...) \ - pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ - ##args) - - #define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+") #define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-") @@ -57,22 +61,16 @@ extern bool mtk_vcodec_dbg; __func__, ##args); \ } while (0) -#define mtk_vcodec_err(h, fmt, args...) \ - pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ - ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) - #define mtk_vcodec_debug_enter(h) mtk_vcodec_debug(h, "+") #define mtk_vcodec_debug_leave(h) mtk_vcodec_debug(h, "-") #else #define mtk_v4l2_debug(level, fmt, args...) {} -#define mtk_v4l2_err(fmt, args...) {} #define mtk_v4l2_debug_enter() {} #define mtk_v4l2_debug_leave() {} #define mtk_vcodec_debug(h, fmt, args...) {} -#define mtk_vcodec_err(h, fmt, args...) {} #define mtk_vcodec_debug_enter(h) {} #define mtk_vcodec_debug_leave(h) {}