From patchwork Wed May 3 20:24:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 41135 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d60pA-00013K-Es; Wed, 03 May 2017 20:24:36 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1d60p8-0003ab-6p; Wed, 03 May 2017 22:24:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757711AbdECUYa (ORCPT + 1 other); Wed, 3 May 2017 16:24:30 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36836 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354AbdECUY3 (ORCPT ); Wed, 3 May 2017 16:24:29 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B856B819F9; Wed, 3 May 2017 22:24:27 +0200 (CEST) Date: Wed, 3 May 2017 22:24:27 +0200 From: Pavel Machek To: Sakari Ailus Cc: Laurent Pinchart , mchehab@kernel.org, kernel list , ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: Re: [PATCHv2] omap3isp: add support for CSI1 bus Message-ID: <20170503202427.GA18616@amd> References: <10545906.Gxg3yScdu4@avalon> <20170215094228.GA8586@amd> <2414221.XNA4JCFMRx@avalon> <20170302090143.GB27818@amd> <20170302101603.GE27818@amd> <20170302112401.GF3220@valkosipuli.retiisi.org.uk> <20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170503195039.GB12396@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170503195039.GB12396@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.5.3.201516 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __FROM_DOMAIN_IN_ANY_CC1 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_MAILTO 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' Hi! > It seems they don't compile. Hmmm. Did I do something wrong? "struct > fwnode_endpoint" seems to be only used in v4l2-fwnode.h; that can't be right...? Next problem is missing dev_fwnode; fixed. Next problem is pavel@duo:/data/l/linux-n900$ git grep fwnode_graph_get_next_endpoint . drivers/media/i2c/smiapp/smiapp-core.c: ep = fwnode_graph_get_next_endpoint(fwnode, NULL); drivers/media/platform/omap3isp/isp.c: while ((fwnode = fwnode_graph_get_next_endpoint(dev_fwnode(dev), So sorry, I guess I should wait for version that compiles ;-). Pavel diff --git a/drivers/base/property.c b/drivers/base/property.c index c458c63..f52a260 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -182,11 +182,6 @@ static int pset_prop_read_string(struct property_set *pset, return 0; } -static inline struct fwnode_handle *dev_fwnode(struct device *dev) -{ - return IS_ENABLED(CONFIG_OF) && dev->of_node ? - &dev->of_node->fwnode : dev->fwnode; -} /** * device_property_present - check if a property of a device is present diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 8bd28ce..9215e23 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -27,4 +27,10 @@ struct fwnode_handle { struct fwnode_handle *secondary; }; +static inline struct fwnode_handle *dev_fwnode(struct device *dev) +{ + return IS_ENABLED(CONFIG_OF) && dev->of_node ? + &dev->of_node->fwnode : dev->fwnode; +} + #endif diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h index d762a55..9e9cfbc 100644 --- a/include/media/v4l2-fwnode.h +++ b/include/media/v4l2-fwnode.h @@ -80,7 +80,7 @@ struct v4l2_fwnode_bus_mipi_csi1 { * @nr_of_link_frequencies: number of elements in link_frequenccies array */ struct v4l2_fwnode_endpoint { - struct fwnode_endpoint base; + /*struct fwnode_endpoint base; */ /* * Fields below this line will be zeroed by * v4l2_fwnode_parse_endpoint()