From patchwork Tue Apr 25 03:12:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 40955 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2quO-0000FM-Pq; Tue, 25 Apr 2017 03:12:56 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-8) with esmtp id 1d2quM-0004J0-kW; Tue, 25 Apr 2017 05:12:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S980230AbdDYDMw (ORCPT + 1 other); Mon, 24 Apr 2017 23:12:52 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33097 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S980228AbdDYDMv (ORCPT ); Mon, 24 Apr 2017 23:12:51 -0400 Received: by mail-pg0-f66.google.com with SMTP id 63so8099599pgh.0 for ; Mon, 24 Apr 2017 20:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uhYn89l4fXvqCBFnkdd6UVM2oiL4LRY/jusAxUP2GjI=; b=IOVZtzb0+0bCj7F8uJhi+sGNSDyUwnCSeyEGc6Fx4D5Pu2onbNgQhJ4mgvI5jSVcAx zH+oId6frtO+/m6KOc/yjX3BYZdKL7E5sx3WeiMYcrO+2WsWMrTsB9+xk4RCRGLUgqDo XbTFCIZU+xm25i/3xqv8B8h5jnAvJmf3cYc3sVyYRSCRo7Z7bv/vrI+bgTWobfaivIJS xSKX+wXbVoUU1PCt7Yfextja82+ttrEdj6gWfhhUVh00Wq23LaOGYUJJo4GZ0tD3zmhB 3De/QXiDJ6MzwcVwj0AtPvRWeVEA6iY1XZKHz88V2Gti9rWHwsFnB9OrCmcGlUAnH1vI w4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uhYn89l4fXvqCBFnkdd6UVM2oiL4LRY/jusAxUP2GjI=; b=ttjkhbXS5GCKBNG376H+YuhwguuwTH7s1dr4GL2pHJ0t48eolRUP7oO5J+b2aI1hQb TyKWZKIKqfRkBn3b5KXb4wuE7tWpqchY6gCAsAhWdue+G3QDyHVJeJQbEAZIE2dWgOdq FmhZeyuBa4TDL0PUr7nrb/fkmvPTCVns7avGj4wBQgSQTAejvM/eZRbP5d/ufjlSVuMn LIbxYCBouBp5FqV81RQ7IHXUAdooPzRRUhCWP5VIzNyhynuMT0CszJXB6QIOFzo3x7/d ZDyoy4M0edKo0KQhWIFw5Up1fNO5Fav5JqPksmQRfg5W8b62EAdLC3zy1rYqwBJtJ27a 2BQQ== X-Gm-Message-State: AN3rC/5MlAH9EeLOgnHcPSQ9Hw1k4oeSyQ9C7U9RdLEcj0YskccIbAUl r9aZ6NF4zSbhRw== X-Received: by 10.99.54.70 with SMTP id d67mr18829906pga.24.1493089971053; Mon, 24 Apr 2017 20:12:51 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id r18sm33051563pfk.109.2017.04.24.20.12.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2017 20:12:50 -0700 (PDT) From: Wei Yongjun To: Hans Verkuil , Mauro Carvalho Chehab Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] rainshadow-cec: Fix missing spin_lock_init() Date: Tue, 25 Apr 2017 03:12:46 +0000 Message-Id: <20170425031246.9592-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.4.25.30917 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI CEC driver") Signed-off-by: Wei Yongjun --- drivers/media/usb/rainshadow-cec/rainshadow-cec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/rainshadow-cec/rainshadow-cec.c b/drivers/media/usb/rainshadow-cec/rainshadow-cec.c index 541ca54..8f562ed 100644 --- a/drivers/media/usb/rainshadow-cec/rainshadow-cec.c +++ b/drivers/media/usb/rainshadow-cec/rainshadow-cec.c @@ -336,6 +336,7 @@ static int rain_connect(struct serio *serio, struct serio_driver *drv) serio_set_drvdata(serio, rain); INIT_WORK(&rain->work, rain_irq_work_handler); mutex_init(&rain->write_lock); + spin_lock_init(&rain->buf_lock); err = serio_open(serio, drv); if (err)