From patchwork Mon Mar 13 19:20:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo F. Padovan" X-Patchwork-Id: 40021 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnVZs-0004Rq-48; Mon, 13 Mar 2017 19:24:20 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1cnVZq-0007tA-0J; Mon, 13 Mar 2017 20:24:19 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754437AbdCMTYG (ORCPT + 1 other); Mon, 13 Mar 2017 15:24:06 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36393 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdCMTUt (ORCPT ); Mon, 13 Mar 2017 15:20:49 -0400 Received: by mail-qk0-f196.google.com with SMTP id n141so38449330qke.3; Mon, 13 Mar 2017 12:20:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7KfFbc+q7PShomNw2/TSQVlGoJ+Kd3drfKRnaMI17qI=; b=kEtQZRfBv4pbjLWtqs/TKi0wygfdhDWu5cntFIfUSUVHalfxATuuHhFqrhBDH3mUmj jpfrYR9sn1mLgfpAAKCGUXb58Y8CyZJ76uEDwBlf63f5WjNrGUIzwVh8Zg4lssbPBhks 5tOgStI6iDjdkKBcwt9oxQRPqcNe47AGdNnV2sZN11TJfovxJuHSsK4AA3DUTDxAK7Wc DzpHQObNVDA8hJiyKpdCLSaEIPJakYLPh6XUF46ybVScmSzksHdbRkumwDYZ8EdbnUFp NLydZdOQQjyd51ryZdurnA14SlZIE11mpLoUDI4l8J5bafeX/hy/fuD5ue9N0yViY9TX F0RA== X-Gm-Message-State: AFeK/H2iEQKDVZJg3FbBSFU9lPy2JQd7jUNhKiUOYqsmUXnBe4ONeARciuoDGClaZ5nEKw== X-Received: by 10.55.4.139 with SMTP id 133mr31369101qke.48.1489432848118; Mon, 13 Mar 2017 12:20:48 -0700 (PDT) Received: from localhost.localdomain ([179.159.9.225]) by smtp.gmail.com with ESMTPSA id a19sm12821047qta.48.2017.03.13.12.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 12:20:47 -0700 (PDT) From: Gustavo Padovan To: linux-media@vger.kernel.org Cc: Hans Verkuil , Mauro Carvalho Chehab , Laurent Pinchart , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Gustavo Padovan Subject: [RFC 02/10] [media] vb2: split out queueing from vb_core_qbuf() Date: Mon, 13 Mar 2017 16:20:27 -0300 Message-Id: <20170313192035.29859-3-gustavo@padovan.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170313192035.29859-1-gustavo@padovan.org> References: <20170313192035.29859-1-gustavo@padovan.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.3.13.191516 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Gustavo Padovan In order to support explicit synchronization we need to divide vb2_core_qbuf() in two parts one, to be executed before the fence signals and another one after that, to do the actual queueing of the buffer. Signed-off-by: Gustavo Padovan --- drivers/media/v4l2-core/videobuf2-core.c | 65 ++++++++++++++++++-------------- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 94afbbf9..0e30fcd 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1363,29 +1363,10 @@ static int vb2_start_streaming(struct vb2_queue *q) return ret; } -int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb) +static int __vb2_core_qbuf(struct vb2_buffer *vb, struct vb2_queue *q) { - struct vb2_buffer *vb; int ret; - vb = q->bufs[index]; - - switch (vb->state) { - case VB2_BUF_STATE_DEQUEUED: - ret = __buf_prepare(vb, pb); - if (ret) - return ret; - break; - case VB2_BUF_STATE_PREPARED: - break; - case VB2_BUF_STATE_PREPARING: - dprintk(1, "buffer still being prepared\n"); - return -EINVAL; - default: - dprintk(1, "invalid buffer state %d\n", vb->state); - return -EINVAL; - } - /* * Add to the queued buffers list, a buffer will stay on it until * dequeued in dqbuf. @@ -1395,11 +1376,6 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb) q->waiting_for_buffers = false; vb->state = VB2_BUF_STATE_QUEUED; - if (pb) - call_void_bufop(q, copy_timestamp, vb, pb); - - trace_vb2_qbuf(q, vb); - /* * If already streaming, give the buffer to driver for processing. * If not, the buffer will be given to driver on next streamon. @@ -1407,10 +1383,6 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb) if (q->start_streaming_called) __enqueue_in_driver(vb); - /* Fill buffer information for the userspace */ - if (pb) - call_void_bufop(q, fill_user_buffer, vb, pb); - /* * If streamon has been called, and we haven't yet called * start_streaming() since not enough buffers were queued, and @@ -1427,6 +1399,41 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb) dprintk(1, "qbuf of buffer %d succeeded\n", vb->index); return 0; } + +int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb) +{ + struct vb2_buffer *vb; + int ret; + + vb = q->bufs[index]; + + switch (vb->state) { + case VB2_BUF_STATE_DEQUEUED: + ret = __buf_prepare(vb, pb); + if (ret) + return ret; + break; + case VB2_BUF_STATE_PREPARED: + break; + case VB2_BUF_STATE_PREPARING: + dprintk(1, "buffer still being prepared\n"); + return -EINVAL; + default: + dprintk(1, "invalid buffer state %d\n", vb->state); + return -EINVAL; + } + + if (pb) + call_void_bufop(q, copy_timestamp, vb, pb); + + trace_vb2_qbuf(q, vb); + + /* Fill buffer information for the userspace */ + if (pb) + call_void_bufop(q, fill_user_buffer, vb, pb); + + return __vb2_core_qbuf(vb, q); +} EXPORT_SYMBOL_GPL(vb2_core_qbuf); /**