From patchwork Fri Mar 3 23:24:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 39742 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjwYw-0008Tt-Bt; Fri, 03 Mar 2017 23:24:38 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1cjwYu-0002LN-3p; Sat, 04 Mar 2017 00:24:38 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbdCCXYM (ORCPT + 1 other); Fri, 3 Mar 2017 18:24:12 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33599 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbdCCXYK (ORCPT ); Fri, 3 Mar 2017 18:24:10 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 7906A819C7; Sat, 4 Mar 2017 00:24:01 +0100 (CET) Date: Sat, 4 Mar 2017 00:24:01 +0100 From: Pavel Machek To: Sakari Ailus Cc: sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, ivo.g.dimitrov.75@gmail.com Subject: Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times) Message-ID: <20170303232400.GA6442@amd> References: <20170220130912.GT16975@valkosipuli.retiisi.org.uk> <20170220135636.GU16975@valkosipuli.retiisi.org.uk> <20170221110721.GD5021@amd> <20170221111104.GD16975@valkosipuli.retiisi.org.uk> <20170225000918.GB23662@amd> <20170225134444.6qzumpvasaow5qoj@ihha.localdomain> <20170302090727.GC27818@amd> <20170302141617.GG3220@valkosipuli.retiisi.org.uk> <20170302145808.GA3315@amd> <20170302151321.GH3220@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170302151321.GH3220@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.3.3.231516 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __FORWARDED_MSG 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' Hi! > > > > > Making the sub-device bus configuration a pointer should be in a separate > > > > > patch. It makes sense since the entire configuration is not valid for all > > > > > sub-devices attached to the ISP anymore. I think it originally was a > > > > > separate patch, but they probably have been merged at some point. I can't > > > > > find it right now anyway. > > > > > > > > Something like this? > > > > > > > > commit df9141c66678b549fac9d143bd55ed0b242cf36e > > > > Author: Pavel > > > > Date: Wed Mar 1 13:27:56 2017 +0100 > > > > > > > > Turn bus in struct isp_async_subdev into pointer; some of our subdevs > > > > (flash, focus) will not need bus configuration. > > > > > > > > Signed-off-by: Pavel Machek > > > > > > I applied this to the ccp2 branch with an improved patch > > > description. > > > > Thanks! > > > > [But the important part is to get subdevices to work on ccp2 based > > branch, and it still fails to work at all if I attempt to enable > > them. I'd like to understand why...] > > Did you add the flash / lens to the async list? The patches currently in the > ccp branch do not include that --- it should be in parsing the flash / > lens-focus properties in omap3isp device's node. I retried, and it fails different way than I assumed. I might be able to debug this one as sensor (and mplayer) still works. Best regards, Pavel --- This is what subdevs support should look like, I guess; but I don't know fwnode stuff well enough. diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index c80397a..36bd359 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2166,6 +2166,8 @@ static int isp_fwnodes_parse(struct device *dev, struct v4l2_async_notifier *notifier) { struct fwnode_handle *fwn = NULL; + struct device_node *node; + int flash = 0; notifier->subdevs = devm_kcalloc( dev, ISP_MAX_SUBDEVS, sizeof(*notifier->subdevs), GFP_KERNEL); @@ -2199,6 +2201,42 @@ static int isp_fwnodes_parse(struct device *dev, notifier->num_subdevs++; } + printk("Going through camera-flashes\n"); + while (notifier->num_subdevs < ISP_MAX_SUBDEVS) { + /* FIXME: fwnode_graph_get_remote_endpoint() + (fwn = fwnode_graph_get_next_endpoint(device_fwnode_handle(dev), fwn, )) */ + struct isp_async_subdev *isd; + + node = of_parse_phandle(dev->of_node, "ti,camera-flashes", flash++); + flash++; + if (!node) + break; + + printk("Having subdevice: %p\n", node); + +#if 1 + isd = devm_kzalloc(dev, sizeof(*isd), GFP_KERNEL); + if (!isd) + goto error; + + notifier->subdevs[notifier->num_subdevs] = &isd->asd; + + + isd->asd.match.of.node = node; + if (!isd->asd.match.of.node) { + dev_warn(dev, "bad remote port parent\n"); + goto error; + } + + isd->asd.match_type = V4L2_ASYNC_MATCH_OF; + notifier->num_subdevs++; +#endif + } + + + if (notifier->num_subdevs == ISP_MAX_SUBDEVS) { + printk("isp: Maybe too many devices?\n"); + } return notifier->num_subdevs; error: