From patchwork Fri Feb 3 11:50:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 39195 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZcOE-0004iH-DZ; Fri, 03 Feb 2017 11:50:54 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1cZcOC-0004ol-6h; Fri, 03 Feb 2017 12:50:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdBCLut (ORCPT + 1 other); Fri, 3 Feb 2017 06:50:49 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33897 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdBCLus (ORCPT ); Fri, 3 Feb 2017 06:50:48 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5E19481727; Fri, 3 Feb 2017 12:50:46 +0100 (CET) Date: Fri, 3 Feb 2017 12:50:45 +0100 From: Pavel Machek To: Sakari Ailus Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: Re: [PATCHv2] dt: bindings: Add support for CSI1 bus Message-ID: <20170203115045.GA1350@amd> References: <20161228183036.GA13139@amd> <20170111225335.GA21553@amd> <20170119214905.GD3205@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170119214905.GD3205@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.2.3.114216 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __FORWARDED_MSG 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' Hi! > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -76,6 +76,11 @@ Optional endpoint properties > > mode horizontal and vertical synchronization signals are provided to the > > slave device (data source) by the master device (data sink). In the master > > mode the data source device is also the source of the synchronization signals. > > +- bus-type: data bus type. Possible values are: > > + 0 - MIPI CSI2 > > + 1 - parallel / Bt656 > > + 2 - MIPI CSI1 > > + 3 - CCP2 > > Actually, thinking about this again --- we only need to explictly specify > busses if we're dealing with either CCP2 or CSI-1. The vast majority of the > actual busses are and continue to be CSI-2 or either parallel or Bt.656. As > they can be implicitly detected, we would have an option to just drop values > 0 and 1 from above, i.e. only leave CSI-1 and CCP2. For now, specifying > CSI-2 or parallel / Bt.656 adds no value as the old DT binaries without > bus-type will need to be supported anyway. Hmm. "Just deleting the others" may be a bit confusing... but what about this? It explains what we can autodetect. Best regards, Pavel diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index 08c4498..d54093b 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -77,10 +77,10 @@ Optional endpoint properties slave device (data source) by the master device (data sink). In the master mode the data source device is also the source of the synchronization signals. - bus-type: data bus type. Possible values are: - 0 - MIPI CSI2 - 1 - parallel / Bt656 - 2 - MIPI CSI1 - 3 - CCP2 + 0 - autodetect based on other properties (MIPI CSI2, parallel, Bt656) + 1 - MIPI CSI1 + 2 - CCP2 + Autodetection is default, and bus-type property may be omitted in that case. - bus-width: number of data lines actively used, valid for the parallel busses. - data-shift: on the parallel data busses, if bus-width is used to specify the number of data lines, data-shift can be used to specify which data lines are