From patchwork Sat Dec 17 01:00:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 38740 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cI3Mk-0000N3-BC; Sat, 17 Dec 2016 01:00:46 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1cI3Mh-0005rF-1Z; Sat, 17 Dec 2016 02:00:45 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757545AbcLQBAe (ORCPT + 1 other); Fri, 16 Dec 2016 20:00:34 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33019 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755003AbcLQBAd (ORCPT ); Fri, 16 Dec 2016 20:00:33 -0500 Received: by mail-pf0-f178.google.com with SMTP id d2so16386075pfd.0 for ; Fri, 16 Dec 2016 17:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=I4c1m/igBHAwvw/Fzgo8epNG9pPBXdMs0aMyuqGrxl4=; b=XV7j6Cj9IZiirfFbHqD65Xjg3cVdLlJzDXjQG8zvkLAGLHSydNmjBQKsgxm4eBTk50 yichpY6hVpMqc2AVLvpDrzUHNL4hSNjqAEFx2HvBXyhZCKjlYlOKzmVV+CBUH3eSMJLY H5FBaLM1dFWt2Gkl7LIqJSZsqpbg7kqyAQQQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=I4c1m/igBHAwvw/Fzgo8epNG9pPBXdMs0aMyuqGrxl4=; b=SqXL6p7hcZWKbjraz/BrAZAXwGARLlK/ho4rGAaZRqM9WyIvNCTguoGgfojO64tWR2 Fsa29nKIez2k75tf7k85QyU5rCvGTmfAPiKDk0NB6yXBWajekdy16yOOf8ExeoYVrpXq 1MqtPzi5CKj9FZCJd/ghIvYvUbFA/V0szxGlSNwG6rIu0sh6jUvDUFULP6gzOSVTLWyp p3knqklwRuivGev3wNOvNjevi6OpLLV3voJ+GbW/sG7hTsV2aE7f78wH2G9cm2Jw1Bz8 b9BwLdylOL+sxo6Vr/IRG9fMX3xLrfiJAjX/LE4dNyiEbPANZIJwaK+RWqFroKnqI7is 0LJw== X-Gm-Message-State: AIkVDXJ93cj8Tp52OnhJYgB06/3YOOJuYy5VtDC538flwrIEHtX8mWvt66ZXj+avooYyirqJ X-Received: by 10.99.116.80 with SMTP id e16mr3953180pgn.135.1481936432557; Fri, 16 Dec 2016 17:00:32 -0800 (PST) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id a22sm14396187pfg.7.2016.12.16.17.00.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 17:00:32 -0800 (PST) Date: Fri, 16 Dec 2016 17:00:31 -0800 From: Kees Cook To: linux-kernel@vger.kernel.org Cc: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , PoChun Lin , Arnd Bergmann , Julia Lawall , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] mtk-vcodec: use designated initializers Message-ID: <20161217010031.GA140323@beast> MIME-Version: 1.0 Content-Disposition: inline Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.12.17.5115 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, DKIM_SIGNATURE 0, INVALID_MSGID_NO_FQDN 0, LEGITIMATE_NEGATE 0, LEGITIMATE_SIGNS 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook --- drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c | 8 ++++---- drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c index b76c80bdf30b..4eb3be37ba14 100644 --- a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c +++ b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c @@ -665,10 +665,10 @@ static int h264_enc_deinit(unsigned long handle) } static const struct venc_common_if venc_h264_if = { - h264_enc_init, - h264_enc_encode, - h264_enc_set_param, - h264_enc_deinit, + .init = h264_enc_init, + .encode = h264_enc_encode, + .set_param = h264_enc_set_param, + .deinit = h264_enc_deinit, }; const struct venc_common_if *get_h264_enc_comm_if(void); diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c index 544f57186243..a6fa145f2c54 100644 --- a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c +++ b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c @@ -470,10 +470,10 @@ static int vp8_enc_deinit(unsigned long handle) } static const struct venc_common_if venc_vp8_if = { - vp8_enc_init, - vp8_enc_encode, - vp8_enc_set_param, - vp8_enc_deinit, + .init = vp8_enc_init, + .encode = vp8_enc_encode, + .set_param = vp8_enc_set_param, + .deinit = vp8_enc_deinit, }; const struct venc_common_if *get_vp8_enc_comm_if(void);