From patchwork Mon Jun 13 19:17:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 34576 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCXNN-0008Rz-76; Mon, 13 Jun 2016 19:18:21 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1bCXNJ-0008Uo-5P; Mon, 13 Jun 2016 21:18:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423527AbcFMTR7 (ORCPT + 1 other); Mon, 13 Jun 2016 15:17:59 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46079 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161352AbcFMTR5 (ORCPT ); Mon, 13 Jun 2016 15:17:57 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id CED36823DC; Mon, 13 Jun 2016 21:17:53 +0200 (CEST) Date: Mon, 13 Jun 2016 21:17:53 +0200 From: Pavel Machek To: Sakari Ailus Cc: Ivaylo Dimitrov , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, linux-media@vger.kernel.org, mchehab@osg.samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH] userspace API definitions for auto-focus coil Message-ID: <20160613191753.GA17459@amd> References: <20160601152439.GQ26360@valkosipuli.retiisi.org.uk> <20160601220840.GA21946@amd> <20160602074544.GR26360@valkosipuli.retiisi.org.uk> <20160602193027.GB7984@amd> <20160602212746.GT26360@valkosipuli.retiisi.org.uk> <20160605190716.GA11321@amd> <575512E5.5030000@gmail.com> <20160611220654.GC26360@valkosipuli.retiisi.org.uk> <20160612084811.GA27446@amd> <20160612112253.GD26360@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160612112253.GD26360@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.6.13.190915 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODY_SIZE_5000_5999 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_NEGATE 0, MSG_THREAD 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' On Sun 2016-06-12 14:22:53, Sakari Ailus wrote: > Hi Pavel, > > On Sun, Jun 12, 2016 at 10:48:11AM +0200, Pavel Machek wrote: > > Hi! > > > > > > >Add userspace API definitions. > > > > > > > > > >Signed-off-by: Pavel Machek > > > > > > > > > >diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > > > >index b6a357a..23011cc 100644 > > > > >--- a/include/uapi/linux/v4l2-controls.h > > > > >+++ b/include/uapi/linux/v4l2-controls.h > > > > >@@ -974,4 +975,9 @@ enum v4l2_detect_md_mode { > > > > > #define V4L2_CID_DETECT_MD_THRESHOLD_GRID (V4L2_CID_DETECT_CLASS_BASE + 3) > > > > > #define V4L2_CID_DETECT_MD_REGION_GRID (V4L2_CID_DETECT_CLASS_BASE + 4) > > > > > > > > > >+/* Control IDs specific to the AD5820 driver as defined by V4L2 */ > > > > >+#define V4L2_CID_FOCUS_AD5820_BASE (V4L2_CTRL_CLASS_CAMERA | 0x10af) > > > > > > Please check V4L2_CID_USER_*_BASE. That's how custom controls are handled > > > nowadays. > > > > So something like this? > > > > Thanks, > > Pavel > > > > diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c > > index 2efa5dc1..b04b471 100644 > > --- a/drivers/media/i2c/ad5820.c > > +++ b/drivers/media/i2c/ad5820.c > > @@ -40,6 +40,11 @@ > > #define AD5820_RAMP_MODE_LINEAR (0 << 3) > > #define AD5820_RAMP_MODE_64_16 (1 << 3) > > > > +/* Control IDs specific to the AD5820 driver as defined by V4L2 */ > > +#define V4L2_CID_FOCUS_AD5820_RAMP_TIME (V4L2_CID_USER_AD5820_BASE+0) > > +#define V4L2_CID_FOCUS_AD5820_RAMP_MODE (V4L2_CID_FOCUS_AD5820_BASE+1) > > + > > + > > We could still define these in a header file that can be included by the > user space. Please use V4L2_CID_AD5820 prefix. Not V4L2_CID_USER_AD5820...? > A separate header file should be used, > e.g. include/uapi/linux/ad5820.h. Ok, separate header file for 2 lines seemed like a bit of overkill, but why not. Something like this? commit 8dd701d2580e41b06bb2285e6bd59a4f1702b4d8 Author: Pavel Date: Mon Jun 13 21:17:15 2016 +0200 Userspace api, as Sakari asked. diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c index 2efa5dc1..ed3facc 100644 --- a/drivers/media/i2c/ad5820.c +++ b/drivers/media/i2c/ad5820.c @@ -32,6 +32,8 @@ #include #include +#include + #define AD5820_NAME "ad5820" /* Register definitions */ @@ -40,6 +42,8 @@ #define AD5820_RAMP_MODE_LINEAR (0 << 3) #define AD5820_RAMP_MODE_64_16 (1 << 3) + + #define CODE_TO_RAMP_US(s) ((s) == 0 ? 0 : (1 << ((s) - 1)) * 50) #define RAMP_US_TO_CODE(c) fls(((c) + ((c)>>1)) / 50) @@ -165,13 +169,13 @@ static int ad5820_set_ctrl(struct v4l2_ctrl *ctrl) coil->focus_absolute = ctrl->val; return ad5820_update_hw(coil); - case V4L2_CID_FOCUS_AD5820_RAMP_TIME: + case V4L2_CID_AD5820_RAMP_TIME: code = RAMP_US_TO_CODE(ctrl->val); ctrl->val = CODE_TO_RAMP_US(code); coil->focus_ramp_time = ctrl->val; break; - case V4L2_CID_FOCUS_AD5820_RAMP_MODE: + case V4L2_CID_AD5820_RAMP_MODE: coil->focus_ramp_mode = ctrl->val; break; } @@ -191,7 +195,7 @@ static const char * const ad5820_focus_menu[] = { static const struct v4l2_ctrl_config ad5820_ctrls[] = { { .ops = &ad5820_ctrl_ops, - .id = V4L2_CID_FOCUS_AD5820_RAMP_TIME, + .id = V4L2_CID_AD5820_RAMP_TIME, .type = V4L2_CTRL_TYPE_INTEGER, .name = "Focus ramping time [us]", .min = 0, @@ -202,7 +206,7 @@ static const struct v4l2_ctrl_config ad5820_ctrls[] = { }, { .ops = &ad5820_ctrl_ops, - .id = V4L2_CID_FOCUS_AD5820_RAMP_MODE, + .id = V4L2_CID_AD5820_RAMP_MODE, .type = V4L2_CTRL_TYPE_MENU, .name = "Focus ramping mode", .min = 0, diff --git a/include/uapi/linux/ad5820.h b/include/uapi/linux/ad5820.h new file mode 100644 index 0000000..d44ba9c --- /dev/null +++ b/include/uapi/linux/ad5820.h @@ -0,0 +1,18 @@ +/* + * AD5820 DAC driver for camera voice coil focus. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + */ + +#ifndef __LINUX_AD5820_H +#define __LINUX_AD5820_H + +#include + +/* Control IDs specific to the AD5820 driver as defined by V4L2 */ +#define V4L2_CID_AD5820_RAMP_TIME (V4L2_CID_AD5820_BASE+0) +#define V4L2_CID_AD5820_RAMP_MODE (V4L2_CID_AD5820_BASE+1) + +#endif diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index 23011cc..015e90b 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -181,6 +181,10 @@ enum v4l2_colorfx { * We reserve 16 controls for this driver. */ #define V4L2_CID_USER_TC358743_BASE (V4L2_CID_USER_BASE + 0x1080) +/* The base for the ad5820 driver controls. + * We reserve 16 controls for this driver. */ +#define V4L2_CID_AD5820_BASE (V4L2_CID_USER_BASE + 0x1090) + /* MPEG-class control IDs */ /* The MPEG controls are applicable to all codec controls * and the 'MPEG' part of the define is historical */ @@ -986,9 +990,4 @@ enum v4l2_detect_md_mode { #define V4L2_CID_MODE_SENSITIVITY (V4L2_CID_MODE_CLASS_BASE+6) #define V4L2_CID_MODE_OPSYSCLOCK (V4L2_CID_MODE_CLASS_BASE+7) -/* Control IDs specific to the AD5820 driver as defined by V4L2 */ -#define V4L2_CID_FOCUS_AD5820_BASE (V4L2_CTRL_CLASS_CAMERA | 0x10af) -#define V4L2_CID_FOCUS_AD5820_RAMP_TIME (V4L2_CID_FOCUS_AD5820_BASE+0) -#define V4L2_CID_FOCUS_AD5820_RAMP_MODE (V4L2_CID_FOCUS_AD5820_BASE+1) - #endif