From patchwork Wed Feb 11 11:08:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis de Bethencourt X-Patchwork-Id: 28196 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YLVCl-0007pG-Ku; Wed, 11 Feb 2015 12:11:39 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1YLVCj-0001pO-3K; Wed, 11 Feb 2015 12:11:39 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbbBKLK4 (ORCPT + 1 other); Wed, 11 Feb 2015 06:10:56 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:38744 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbbBKLKz (ORCPT ); Wed, 11 Feb 2015 06:10:55 -0500 Received: by mail-we0-f178.google.com with SMTP id w62so2635032wes.9; Wed, 11 Feb 2015 03:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:date:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=+IIq4mqReOKPtTSNM7GMFi2n8ng67dPwMW5PjBSaHrI=; b=IzCyUPPx2uSGACJEO56pAZxXrerN/UNwATHpVCmXjhPWRqTGPTN/xJnKA3qxtLlha7 py+5atM/cRgqih5pkJzES+3r6V7ESpPbaXJ0ppZ/zn/GEQKPtO6Wb/MjK+mf8eZKfXaZ rQ1h+EZnk8wl72+r4MwqLeo2WPVFccjStykaowNjMLYrD2QjBDvZpsL5Nj5t6JOMKv5g +N6109041LMqM+A0+9Aaep9UBF/3RPd0dR4l8sWU9heTWhprf/5TBF09n3JZFe952oTK gywTyB6i5QP/a8mujyrKdThzhO5ohQn/IPgTt4TsdDQ+H84k8vA6JPo/kHA93bXjHZCo HZRg== X-Received: by 10.181.27.199 with SMTP id ji7mr4520961wid.76.1423653054405; Wed, 11 Feb 2015 03:10:54 -0800 (PST) Received: from localhost ([212.250.200.210]) by mx.google.com with ESMTPSA id e4sm757233wjw.48.2015.02.11.03.10.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 03:10:52 -0800 (PST) From: Luis de Bethencourt X-Google-Original-From: Luis de Bethencourt Date: Wed, 11 Feb 2015 11:08:51 +0000 To: linux-media@vger.kernel.org Cc: mchehab@osg.samsung.com, crop@iki.fi, linux-kernel@vger.kernel.org Subject: [PATCH v2] rtl2832: remove compiler warning Message-ID: <20150211110851.GA30505@biggie> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.11.110323 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, FROM_NAME_PHRASE 0, INVALID_MSGID_NO_FQDN 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_SUBJECT 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' Cleaning up the following compiler warning: rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings. Signed-off-by: Luis de Bethencourt Reviewed-by: Antti Palosaari --- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c index 5d2d8f4..20fa245 100644 --- a/drivers/media/dvb-frontends/rtl2832.c +++ b/drivers/media/dvb-frontends/rtl2832.c @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) struct rtl2832_dev *dev = fe->demodulator_priv; struct i2c_client *client = dev->client; int ret; - u32 tmp; + u32 uninitialized_var(tmp); dev_dbg(&client->dev, "\n");