From patchwork Thu Feb 5 05:52:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cho KyongHo X-Patchwork-Id: 28171 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YJFNW-0000cZ-6n; Thu, 05 Feb 2015 06:53:26 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1YJFNT-0007ZJ-0F; Thu, 05 Feb 2015 06:53:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100AbbBEFwq (ORCPT + 1 other); Thu, 5 Feb 2015 00:52:46 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:21418 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbBEFwo (ORCPT ); Thu, 5 Feb 2015 00:52:44 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJA00GSZAZU5660@mailout3.samsung.com>; Thu, 05 Feb 2015 14:52:42 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.133]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 7C.61.19034.A2503D45; Thu, 05 Feb 2015 14:52:42 +0900 (KST) X-AuditID: cbfee691-f79b86d000004a5a-35-54d3052ad71e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id FB.63.20081.A2503D45; Thu, 05 Feb 2015 14:52:42 +0900 (KST) Received: from DO-PULLIP-CHO08.dsn.sec.samsung.com ([12.36.165.149]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NJA00LN6AZUPA60@mmp2.samsung.com>; Thu, 05 Feb 2015 14:52:42 +0900 (KST) Date: Thu, 05 Feb 2015 14:52:42 +0900 From: Cho KyongHo To: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org Cc: mchehab@osg.samsung.com, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com Subject: [PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation Message-id: <20150205145242.ebb07029fa8664144d687697@samsung.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.10.14; i686-pc-mingw32) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsWyRsSkVVeL9XKIwcPXOhZLfu5isuicuITd 4vKuOWwWPRu2slqsflbhwOox5fdGVo/ZHTNZPbb032X3+LxJLoAlissmJTUnsyy1SN8ugStj yqUuxoL3nBWPjq9gb2DcwtHFyMkhIWAi0TRjPRuELSZx4R6IzcUhJLCUUaLrdzN7FyMHWNH7 VaEQ8emMEpdXN7JAOJOZJNZ/XwfWzSKgKvHk8T9GEJtNQEti9dzjYLaIQJLEn1lfWUBsZoEI iXlbnzCCDBUW8JL4+FkKJMwr4CjxY+U1dogjLCT2r33ABBEXlPgx+R5Uq5bE5m1NrBC2vMTm NW+ZQW6QEJjOLrF4dTMrxA0CEt8mH2KBOFpWYtMBZoiZkhIHV9xgmcAoMgvJ2FlIxs5CMnYB I/MqRtHUguSC4qT0IlO94sTc4tK8dL3k/NxNjMAoOf3v2cQdjPcPWB9iFOBgVOLhtdh3KUSI NbGsuDL3EKMp0BUTmaVEk/OBsZhXEm9obGZkYWpiamxkbmmmJM6rI/0zWEggPbEkNTs1tSC1 KL6oNCe1+BAjEwenVANjL5O4r3rZYaEHi8/ILlI1cPyRc1Dcaz2//VFjbaOv05R+eqfMmDjd yvpn/gX/QrcvKzfb8mbv+vdBUO7RJO1pjE9qDeI0+ax3+e/3jWs3uRW28eXur588DadeZE19 ZB7ZkpsnVxpavUBQ/kBfgL3qd78JQktPL9D47f6i+J5f/61fH+Nf3S5VYinOSDTUYi4qTgQA bxp1A40CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jQV0t1sshBu2nNCyW/NzFZNE5cQm7 xeVdc9gsejZsZbVY/azCgdVjyu+NrB6zO2ayemzpv8vu8XmTXABLVAOjTUZqYkpqkUJqXnJ+ SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QXiWFssScUqBQQGJxsZK+HaYJ oSFuuhYwjRG6viFBcD1GBmggYR1jxpRLXYwF7zkrHh1fwd7AuIWji5GDQ0LAROL9qtAuRk4g U0ziwr31bF2MXBxCAtMZJS6vbmSBcCYzSaz/vo4NpIpFQFXiyeN/jCA2m4CWxOq5x8FsEYEk iT+zvrKA2MwCERLztj5hBFkgLOAl8fGzFEiYV8BR4sfKa+wQyywk9q99wAQRF5T4MfkeVKuW xOZtTawQtrzE5jVvmScw8s1CUjYLSdksJGULGJlXMYqmFiQXFCel5xrqFSfmFpfmpesl5+du YgTH4DOpHYwrGywOMQpwMCrx8FruuxQixJpYVlyZe4hRgoNZSYTX9y1QiDclsbIqtSg/vqg0 J7X4EKMp0NMTmaVEk/OB6SGvJN7Q2MTMyNLIzMLIxNxcSZxXyb4tREggPbEkNTs1tSC1CKaP iYNTqoFxrej0jveVPhnXHYo88j8VhyrtYTu6b2/lItPJn6/fkl3sN9dH7c/3hl3M8R9rv99I mfElVk3Kt25vtKf9FuVnGQ0v/681++MuNX3l77x8nX+vGZfYe2cyX2510THx2HVRrsZDxHLx k5mZHmo7WrqLF739mNY31b4re+U0PsFfuy6/nLpnx4ZbSizFGYmGWsxFxYkA8sGKv9cCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.5.54219 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' The slab for vm_area_struct which is vm_area_cachep is already prepared for the general use. Instead of kmalloc() for the vma copy for userptr, allocation from vm_area_cachep is more beneficial. CC: Mauro Carvalho Chehab CC: Hans Verkuil CC: Laurent Pinchart Signed-off-by: Cho KyongHo --- drivers/media/v4l2-core/videobuf2-memops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-memops.c b/drivers/media/v4l2-core/videobuf2-memops.c index 81c1ad8..dd06efa 100644 --- a/drivers/media/v4l2-core/videobuf2-memops.c +++ b/drivers/media/v4l2-core/videobuf2-memops.c @@ -37,7 +37,7 @@ struct vm_area_struct *vb2_get_vma(struct vm_area_struct *vma) { struct vm_area_struct *vma_copy; - vma_copy = kmalloc(sizeof(*vma_copy), GFP_KERNEL); + vma_copy = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL); if (vma_copy == NULL) return NULL; @@ -75,7 +75,7 @@ void vb2_put_vma(struct vm_area_struct *vma) if (vma->vm_file) fput(vma->vm_file); - kfree(vma); + kmem_cache_free(vm_area_cachep, vma); } EXPORT_SYMBOL_GPL(vb2_put_vma);