From patchwork Wed Oct 8 15:49:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 26373 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1XbtaX-0007bQ-8D; Wed, 08 Oct 2014 17:55:41 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1XbtaU-0004Hh-1d; Wed, 08 Oct 2014 17:55:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754201AbaJHPzg (ORCPT + 1 other); Wed, 8 Oct 2014 11:55:36 -0400 Received: from smtp208.alice.it ([82.57.200.104]:3395 "EHLO smtp208.alice.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbaJHPzf (ORCPT ); Wed, 8 Oct 2014 11:55:35 -0400 X-Greylist: delayed 323 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Oct 2014 11:55:34 EDT Received: from jcn (87.1.17.211) by smtp208.alice.it (8.6.060.43) id 540DA437062861DF; Wed, 8 Oct 2014 17:50:03 +0200 Date: Wed, 8 Oct 2014 17:49:57 +0200 From: Antonio Ospite To: Jacek Anaszewski Cc: Hans de Goede , linux-media@vger.kernel.org, kyungmin.park@samsung.com, s.nawrocki@samsung.com, Mauro Carvalho Chehab , Hans Verkuil Subject: Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera Message-Id: <20141008174957.8451ebb426619d88d7a30cfd@ao2.it> In-Reply-To: <54353AA3.3040506@samsung.com> References: <1412757980-23570-1-git-send-email-j.anaszewski@samsung.com> <1412757980-23570-2-git-send-email-j.anaszewski@samsung.com> <54353124.1060704@redhat.com> <54353AA3.3040506@samsung.com> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM/Vb; ]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.10.8.154820 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' On Wed, 08 Oct 2014 15:22:43 +0200 Jacek Anaszewski wrote: > Hi Hans, > > On 10/08/2014 02:42 PM, Hans de Goede wrote: > > Hi, > > > > On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: > >> The plugin provides support for the media device on Exynos4 SoC. > >> Added is also a media device configuration file parser. > >> The media configuration file is used for conveying information > >> about media device links that need to be established as well > >> as V4L2 user control ioctls redirection to a particular > >> sub-device. > >> > >> The plugin performs single plane <-> multi plane API conversion, > >> video pipeline linking and takes care of automatic data format > >> negotiation for the whole pipeline, after intercepting > >> VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls. > >> > >> Signed-off-by: Jacek Anaszewski > >> Acked-by: Kyungmin Park > >> Cc: Mauro Carvalho Chehab > >> Cc: Hans Verkuil > >> --- > >> configure.ac | 1 + > >> lib/Makefile.am | 5 +- > >> lib/libv4l-exynos4-camera/Makefile.am | 7 + > >> .../libv4l-devconfig-parser.h | 145 ++ > >> lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c | 2486 ++++++++++++++++++++ > >> 5 files changed, 2642 insertions(+), 2 deletions(-) > >> create mode 100644 lib/libv4l-exynos4-camera/Makefile.am > >> create mode 100644 lib/libv4l-exynos4-camera/libv4l-devconfig-parser.h > >> create mode 100644 lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c > > > > Ugh, that is a big plugin. Can you please split out the parser stuff > > into a separate file ? > > Yes, I tried to split it, but spent so much time fighting with > autotools, that I decided to submit it in this form and ask > more experienced v4l-utils build system maintainers for the advice. > I mentioned this in the cover letter. > What autotools issue in particular? The following change followed by "automake && ./configure" should be enough to add a new file libv4l-devconfig-parser.c: If you wanted to completely reset the build environment you could even use "git clean", FWIW I have this "git distclean" alias in ~/.gitconfig: [alias] distclean = clean -f -d -X You'll need to rerun "autoreconf -i" after such a cleanup. Ciao, Antonio diff --git a/lib/libv4l-exynos4-camera/Makefile.am b/lib/libv4l-exynos4-camera/Makefile.am index 3552ec8..14d461a 100644 --- a/lib/libv4l-exynos4-camera/Makefile.am +++ b/lib/libv4l-exynos4-camera/Makefile.am @@ -2,6 +2,6 @@ if WITH_V4L_PLUGINS libv4l2plugin_LTLIBRARIES = libv4l-exynos4-camera.la endif -libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c +libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c libv4l-devconfig-parser.c libv4l_exynos4_camera_la_CPPFLAGS = -fvisibility=hidden -std=gnu99 libv4l_exynos4_camera_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -lpthread