From patchwork Tue Apr 22 19:52:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 23761 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mailbox.tu-berlin.de ([130.149.7.33] helo=mail.tu-berlin.de) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Wcgob-0001ov-8M; Tue, 22 Apr 2014 21:57:13 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1WcgoZ-000594-k3; Tue, 22 Apr 2014 21:57:12 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755073AbaDVTwJ (ORCPT + 1 other); Tue, 22 Apr 2014 15:52:09 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55789 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbaDVTwI (ORCPT ); Tue, 22 Apr 2014 15:52:08 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 220E28196C; Tue, 22 Apr 2014 21:52:07 +0200 (CEST) Date: Tue, 22 Apr 2014 21:52:06 +0200 From: Pavel Machek To: pavel@ucw.cz, hans.verkuil@cisco.com, m.chehab@samsung.com, ext-eero.nurkkala@nokia.com, nils.faerber@kernelconcepts.de, joni.lapilainen@gmail.com, freemangordon@abv.bg, sre@ring0.de, dan.carpenter@oracle.com, pali.rohar@gmail.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCHv2] radio-bcm2048.c: fix wrong overflow check Message-ID: <20140422195206.GA32663@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.4.22.194518 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_TO_X5 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NS , __USER_AGENT 0' From: Pali Rohár Fix wrong overflow check in radio-bcm2048. Signed-off-by: Pali Rohár Signed-off-by: Pavel Machek Reported-by: Dan Carpenter --- Nothing in patch changed, just added CCs, and From/Reported-by headers. diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index b2cd3a8..bbf236e 100644 --- a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ -737,7 +737,7 @@ static int bcm2048_set_region(struct bcm2048_device *bdev, u8 region) int err; u32 new_frequency = 0; - if (region > ARRAY_SIZE(region_configs)) + if (region >= ARRAY_SIZE(region_configs)) return -EINVAL; mutex_lock(&bdev->mutex);