From patchwork Sat Jan 7 00:45:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Endriss X-Patchwork-Id: 9399 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1RjKRY-0002NX-Qk for patchwork@linuxtv.org; Sat, 07 Jan 2012 01:47:32 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for id 1RjKRX-0003ew-HT; Sat, 07 Jan 2012 01:47:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758826Ab2AGArK (ORCPT ); Fri, 6 Jan 2012 19:47:10 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:45130 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758716Ab2AGArI (ORCPT ); Fri, 6 Jan 2012 19:47:08 -0500 Received: (qmail invoked by alias); 07 Jan 2012 00:47:06 -0000 Received: from p54A849F2.dip.t-dialin.net (HELO charon.escape-edv.de) [84.168.73.242] by mail.gmx.net (mp006) with SMTP; 07 Jan 2012 01:47:06 +0100 X-Authenticated: #476490 X-Provags-ID: V01U2FsdGVkX19yOOI68ZRyXII23Bx0I3CzRD11tCjPgVqF51qeP9 rxZ5icrCrATcID Received: from orion.escape-edv.de (192.168.1.10) by charon.escape-edv.de (192.168.1.9) with esmtp ; Sat, 07 Jan 2012 01:46:34 +0100 From: Oliver Endriss Organization: ESCAPE GmbH EDV-Loesungen To: Mauro Carvalho Chehab Subject: Re: [PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor' Date: Sat, 7 Jan 2012 01:45:40 +0100 User-Agent: KMail/1.9.6 Cc: Linux Media Mailing List References: <201201041945.58852@orion.escape-edv.de> <4F07477C.50900@redhat.com> In-Reply-To: <4F07477C.50900@redhat.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201201070145.40842@orion.escape-edv.de> X-Y-GMX-Trusted: 0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.1.7.1815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TP_8859_1 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FW_1LN_BOT_MSGID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __STOCK_PHRASE_7 0, __TO_MALFORMED_2 0, __URI_NS , __USER_AGENT 0' On Friday 06 January 2012 20:11:56 Mauro Carvalho Chehab wrote: > On 04-01-2012 16:45, Oliver Endriss wrote: > > Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor' > > As a result of this commit, DVB-T tuning did not work anymore. > > > > Signed-off-by: Oliver Endriss > > > > diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c > > index 36e1c82..13f22a1 100644 > > --- a/drivers/media/dvb/frontends/drxk_hard.c > > +++ b/drivers/media/dvb/frontends/drxk_hard.c > > @@ -6235,6 +6235,8 @@ static int drxk_set_parameters(struct dvb_frontend *fe) > > case SYS_DVBC_ANNEX_C: > > state->m_itut_annex_c = true; > > break; > > + case SYS_DVBT: > > + break; > > default: > > return -EINVAL; > > } > > > Hi Oliver, > > Thanks for the patch! > > It become obsoleted by the patch that converted the driver > to create just one frontend: > http://git.linuxtv.org/media_tree.git/commitdiff/fa4b2a171d42ffc512b3a86922ad68e1355eb17a Agreed. > While I don't have DVB-T signal here, the logs were showing that the driver is > switching properly between DVB-T and DVB-C. > > Yet, I'd appreciate if you could test it with a real signal, > for us to be 100% sure that everything is working as expected. A quick test showed that switching to DVB-T works. Sorry, I do not have a DVB-C signal here. Btw, there are two lines, which are not harmful, but should be removed (bad formatting/dead code). CU Oliver --- drxk_hard.c.old 2012-01-07 01:40:00.000000000 +0100 +++ drxk_hard.c 2012-01-07 01:40:30.000000000 +0100 @@ -6236,8 +6236,6 @@ static int drxk_set_parameters(struct dv SetOperationMode(state, OM_QAM_ITU_C); else SetOperationMode(state, OM_QAM_ITU_A); - break; - state->m_itut_annex_c = true; break; case SYS_DVBT: if (!state->m_hasDVBT)