From patchwork Thu Oct 27 05:54:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitri Belimov X-Patchwork-Id: 8210 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1RJIv7-0002MP-B9; Thu, 27 Oct 2011 07:54:51 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1RJIv6-00016G-H9; Thu, 27 Oct 2011 07:54:28 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752444Ab1J0FyR (ORCPT + 3 others); Thu, 27 Oct 2011 01:54:17 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:62337 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019Ab1J0FyR (ORCPT ); Thu, 27 Oct 2011 01:54:17 -0400 Received: by wwe6 with SMTP id 6so3587088wwe.1 for ; Wed, 26 Oct 2011 22:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=UMRZpCBVJnEYzp7mLEKVySz7GKGU4gxr/H9u7XFt5W0=; b=Fk9wFawNldbjsFTr+CsOZfLtDVLkyFqoqMo9wkEcSIo5nZN4+XKftOVzYTM2yS6zjB bplcWtlCBkGIPXItLJmMtXP1UTx47V7GBtrTNzVPiVen2NlZVEeheemUx59OWnbcvNe7 +e6LxYLSDX3fuwftLGFg6ifHx0MYGf/QV9Y24= Received: by 10.227.206.200 with SMTP id fv8mr14068140wbb.11.1319694855782; Wed, 26 Oct 2011 22:54:15 -0700 (PDT) Received: from glory.local ([83.234.160.236]) by mx.google.com with ESMTPS id y38sm6619864wbm.2.2011.10.26.22.54.12 (version=SSLv3 cipher=OTHER); Wed, 26 Oct 2011 22:54:13 -0700 (PDT) Date: Thu, 27 Oct 2011 15:54:09 +1000 From: Dmitri Belimov To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Subject: Re: [PATCH] FM1216ME_MK3 AUX byte for FM mode Message-ID: <20111027155409.3d6f8bbd@glory.local> In-Reply-To: <4E75E799.1010307@redhat.com> References: <20090423154046.7b54f7cc@glory.loctelecom.ru> <4E75E799.1010307@redhat.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.10.27.54815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FORGED_FROM_GMAIL 0.1, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, ECARD_WORD 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' X-LSpam-Score: 1.1 (+) X-LSpam-Report: No, score=1.1 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, KB_DATE_CONTAINS_TAB=2.751, RCVD_IN_DNSWL_MED=-2.3, TAB_IN_FROM=2.494, T_DKIM_INVALID=0.01, T_FRT_BELOW2=0.01, T_TVD_MIME_EPI=0.01 autolearn=no Hi Mauro I found TV card and test this patch. Audio is better. Please apply. With my best regards, Dmitry. > Hi Dmitri, > > Em 23-04-2009 02:40, Dmitri Belimov escreveu: > > Hi All > > > > Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It > > can be usefull for other tuners. > > Hmm... Found this patch. It were never applied, but it may make some > sense to apply it. > > Could you please double-check if this patch is still valid, and, if > so, re-send it to me? > > Thanks! > Mauro > > > > > > diff -r 00a84f86671d > > linux/drivers/media/common/tuners/tuner-simple.c --- > > a/linux/drivers/media/common/tuners/tuner-simple.c Mon Apr > > 20 22:07:44 2009 +0000 +++ > > b/linux/drivers/media/common/tuners/tuner-simple.c Thu Apr > > 23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc) > > tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); > > + /* Write AUX byte */ > > + switch (priv->type) { > > + case TUNER_PHILIPS_FM1216ME_MK3: > > + buffer[2] = 0x98; > > + buffer[3] = 0x20; /* set TOP AGC */ > > + rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, > > 4); > > + if (4 != rc) > > + tuner_warn("i2c i/o error: rc == %d > > (should be 4)\n", rc); > > + break; > > + } > > + > > return 0; > > } > > > > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov > > > > > > > > With my best regards, Dmitry. > diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c index f8ee29e..4092200 100644 --- a/drivers/media/common/tuners/tuner-simple.c +++ b/drivers/media/common/tuners/tuner-simple.c @@ -751,6 +751,17 @@ static int simple_set_radio_freq(struct dvb_frontend *fe, if (4 != rc) tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); + /* Write AUX byte */ + switch (priv->type) { + case TUNER_PHILIPS_FM1216ME_MK3: + buffer[2] = 0x98; + buffer[3] = 0x20; /* set TOP AGC */ + rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4); + if (4 != rc) + tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); + break; + } + return 0; } Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov