From patchwork Sun Jul 3 22:42:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oliver Endriss X-Patchwork-Id: 7362 Return-path: Envelope-to: mchehab@pedra Delivery-date: Sun, 03 Jul 2011 19:45:26 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1QdVPp-0005E7-Md for mchehab@pedra; Sun, 03 Jul 2011 19:45:26 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Sun, 03 Jul 2011 19:45:25 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QdVO9-0003u3-Hw; Sun, 03 Jul 2011 22:43:41 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057Ab1GCWn1 (ORCPT + 1 other); Sun, 3 Jul 2011 18:43:27 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:47033 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751416Ab1GCWn0 (ORCPT ); Sun, 3 Jul 2011 18:43:26 -0400 Received: (qmail invoked by alias); 03 Jul 2011 22:43:24 -0000 Received: from p5DE56A4E.dip.t-dialin.net (HELO charon.escape-edv.de) [93.229.106.78] by mail.gmx.net (mp015) with SMTP; 04 Jul 2011 00:43:24 +0200 X-Authenticated: #476490 X-Provags-ID: V01U2FsdGVkX18Baphs2woBvqc5LeYUV2H2VT1pQzseoMiTQrxwei y3BJP2L4+BpSnM Received: from orion.escape-edv.de (192.168.1.10) by charon.escape-edv.de (192.168.1.9) with esmtp ; Mon, 04 Jul 2011 00:45:43 +0200 From: Oliver Endriss Organization: ESCAPE GmbH EDV-Loesungen To: "Linux Media Mailing List" Subject: Re: [DVB] TT S-1500b tuning issue Date: Mon, 4 Jul 2011 00:42:59 +0200 User-Agent: KMail/1.9.6 Cc: =?iso-8859-1?q?S=E9bastien_RAILLARD?= (COEXSI) , Malcolm Priestley References: <00a301cc365e$b6d415c0$247c4140$@coexsi.fr> In-Reply-To: <00a301cc365e$b6d415c0$247c4140$@coexsi.fr> MIME-Version: 1.0 Message-Id: <201107040043.00393@orion.escape-edv.de> X-Y-GMX-Trusted: 0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: On Wednesday 29 June 2011 15:16:10 Sébastien RAILLARD wrote: > Dear all, > > We have found what seems to be a tuning issue in the driver for the ALPS > BSBE1-D01A used in the new TT-S-1500b card from Technotrend. > On some transponders, like ASTRA 19.2E 11817-V-27500, the card can work very > well (no lock issues) for hours. > > On some other transponders, like ASTRA 19.2E 11567-V-22000, the card nearly > never manage to get the lock: it's looking like the signal isn't good > enough. Afaics the problem is caused by the tuning loop for (tm = -6; tm < 7;) in stv0288_set_frontend(). I doubt that this code works reliably. Apparently it never obtains a lock within the given delay (30us). Could you please try the attached patch? It disables the loop and tries to tune to the center frequency. CU Oliver diff --git a/drivers/media/dvb/frontends/stv0288.c b/drivers/media/dvb/frontends/stv0288.c index 8e0cfad..4ffe7da 100644 --- a/drivers/media/dvb/frontends/stv0288.c +++ b/drivers/media/dvb/frontends/stv0288.c @@ -488,6 +488,10 @@ static int stv0288_set_frontend(struct dvb_frontend *fe, /* Carrier lock control register */ stv0288_writeregI(state, 0x15, 0xc5); +#if 1 /* TEST */ + stv0288_writeregI(state, 0x2b, 0); + stv0288_writeregI(state, 0x2c, 0); +#else tda[0] = 0x2b; /* CFRM */ tda[2] = 0x0; /* CFRL */ for (tm = -6; tm < 7;) { @@ -503,6 +507,7 @@ static int stv0288_set_frontend(struct dvb_frontend *fe, stv0288_writeregI(state, 0x2c, tda[2]); udelay(30); } +#endif state->tuner_frequency = c->frequency; state->fec_inner = FEC_AUTO;