From patchwork Thu Jun 9 11:10:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 7220 Return-path: Envelope-to: mchehab@pedra Delivery-date: Thu, 09 Jun 2011 08:34:51 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1QUdVj-0001GQ-EM for mchehab@pedra; Thu, 09 Jun 2011 08:34:51 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Thu, 09 Jun 2011 08:34:51 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QUd9C-00055d-8M; Thu, 09 Jun 2011 11:11:34 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674Ab1FILLc (ORCPT + 1 other); Thu, 9 Jun 2011 07:11:32 -0400 Received: from d1.icnet.pl ([212.160.220.21]:38415 "EHLO d1.icnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753660Ab1FILLb (ORCPT ); Thu, 9 Jun 2011 07:11:31 -0400 Received: from 87-205-12-81.ip.netia.com.pl ([87.205.12.81] helo=vclass.localnet) by d1.icnet.pl with asmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1QUd96-0004UN-Tw; Thu, 09 Jun 2011 13:11:29 +0200 From: Janusz Krzysztofik Organization: Tele-Info-System, Poznan, PL To: Linux Media Mailing List Subject: [PATCH 3.0] soc_camera: OMAP1: stop falling back to dma-sg on single -ENOMEM Date: Thu, 9 Jun 2011 13:10:13 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.36-gentoo-r5; KDE/4.4.5; i686; ; ) Cc: Guennadi Liakhovetski , Mauro Carvalho Chehab MIME-Version: 1.0 Message-Id: <201106091310.31674.jkrzyszt@tis.icnet.pl> X-SA-Exim-Scanned: No (on d1.icnet); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Since commit 6d3163ce86dd386b4f7bda80241d7fea2bc0bb1d, "mm: check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE", the OMAP1 camera driver behaviour while in videobuf-dma-contig mode can be observed as much more stable than before. Once all application programs are started up and nothing unexpected happens in the system, consecutive device open()s tend to succeed with almost 100% reliability. While the result is still not perfect, still prone to occasional -ENOMEM failures, I think there is no longer a need to fall back to more reliable but less effective, more resource hungry videobuf-dma-sg mode if a single open() fails, as long as users are still able to switch DMA modes from user space over the driver provided sysfs interface, should videobuf-dma-contig mode still happen to keep failing for them. Tested on Amstrad Delta. Signed-off-by: Janusz Krzysztofik --- Hi, While this patch is not a classic fix, not correcting anything that could be considered as a bug or regression, it is a simple consequence of unexpected but very welcome enhancement introduced during this merge window, so I hope it can be accepted in the rc cycle for that reason. Moreover, it provides no new, but simplifies existing code by removing no longer needed bits. Thanks, Janusz drivers/media/video/omap1_camera.c | 37 +------------------------------------ 1 file changed, 1 insertion(+), 36 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- git/drivers/media/video/omap1_camera.c.orig 2011-06-06 18:07:54.000000000 +0200 +++ git/drivers/media/video/omap1_camera.c 2011-06-09 12:04:09.000000000 +0200 @@ -172,9 +172,6 @@ struct omap1_cam_dev { struct omap1_cam_buf *ready; enum omap1_cam_vb_mode vb_mode; - int (*mmap_mapper)(struct videobuf_queue *q, - struct videobuf_buffer *buf, - struct vm_area_struct *vma); u32 reg_cache[0]; }; @@ -1352,28 +1349,6 @@ static int omap1_cam_try_fmt(struct soc_ static bool sg_mode; -/* - * Local mmap_mapper wrapper, - * used for detecting videobuf-dma-contig buffer allocation failures - * and switching to videobuf-dma-sg automatically for future attempts. - */ -static int omap1_cam_mmap_mapper(struct videobuf_queue *q, - struct videobuf_buffer *buf, - struct vm_area_struct *vma) -{ - struct soc_camera_device *icd = q->priv_data; - struct soc_camera_host *ici = to_soc_camera_host(icd->dev.parent); - struct omap1_cam_dev *pcdev = ici->priv; - int ret; - - ret = pcdev->mmap_mapper(q, buf, vma); - - if (ret == -ENOMEM) - sg_mode = true; - - return ret; -} - static void omap1_cam_init_videobuf(struct videobuf_queue *q, struct soc_camera_device *icd) { @@ -1391,18 +1366,8 @@ static void omap1_cam_init_videobuf(stru V4L2_BUF_TYPE_VIDEO_CAPTURE, V4L2_FIELD_NONE, sizeof(struct omap1_cam_buf), icd, &icd->video_lock); - /* use videobuf mode (auto)selected with the module parameter */ + /* use videobuf mode selected with the module parameter */ pcdev->vb_mode = sg_mode ? OMAP1_CAM_DMA_SG : OMAP1_CAM_DMA_CONTIG; - - /* - * Ensure we substitute the videobuf-dma-contig version of the - * mmap_mapper() callback with our own wrapper, used for switching - * automatically to videobuf-dma-sg on buffer allocation failure. - */ - if (!sg_mode && q->int_ops->mmap_mapper != omap1_cam_mmap_mapper) { - pcdev->mmap_mapper = q->int_ops->mmap_mapper; - q->int_ops->mmap_mapper = omap1_cam_mmap_mapper; - } } static int omap1_cam_reqbufs(struct soc_camera_device *icd,