From patchwork Wed Jan 19 14:28:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 5628 Return-path: Envelope-to: mchehab@pedra Delivery-date: Wed, 19 Jan 2011 12:31:55 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1PfZ4l-0001sZ-CH for mchehab@pedra; Wed, 19 Jan 2011 12:31:55 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Wed, 19 Jan 2011 12:31:55 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PfZ25-0002Ii-W1; Wed, 19 Jan 2011 14:29:10 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754162Ab1ASO3H (ORCPT + 1 other); Wed, 19 Jan 2011 09:29:07 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:37808 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895Ab1ASO3F (ORCPT ); Wed, 19 Jan 2011 09:29:05 -0500 Received: by wyb28 with SMTP id 28so992286wyb.19 for ; Wed, 19 Jan 2011 06:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=vsDPbd7KoTqHZ1saolX6nrzjPAccfD+mWE/B7zkw3xI=; b=mBjfyIQY7ei6YTb/ATVmbD6HTUbKjjlCiNhMxoy3HCfG+y7AX/+wxzfknRW39vzD3C hwnsp2NKE9pYbJRGfY5cyubToCD+bTRmDRVsUBEOu/3ErrO2v6SUJ719v50ESaHiwJmb 1SPJJga4rVqoszr3UKEiq1G/TiPUZ+4/lo5AI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=GJNPQ/MnNDV9TeoxLHmsMT7UfDD6dxtf6yZGt1jf58LRXckmjAsIbWH5IG1qKmLrkS f4Ch4+2wbOhj/LjNaZcfagvLObr6aFjiqV4vriNnEYlhFjyCuWYmruz5TEj1w2NOR8Mp bkNEd5QA7Rep8nnYqtfZLFTAdesjcYkx7POcA= Received: by 10.227.136.195 with SMTP id s3mr873111wbt.19.1295447322916; Wed, 19 Jan 2011 06:28:42 -0800 (PST) Received: from bicker ([41.202.225.146]) by mx.google.com with ESMTPS id n78sm3693224weq.3.2011.01.19.06.28.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 19 Jan 2011 06:28:42 -0800 (PST) Date: Wed, 19 Jan 2011 17:28:27 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Patrick Boettcher , Olivier Grenie , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 1/2] [media] dib9000: fix return type in dib9000_mbx_send_attr() Message-ID: <20110119142827.GP2721@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: dib9000_mbx_send_attr() returns an int. It doesn't work to save negative error codes in an unsigned char, so I've made "ret" an int type. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/dvb/frontends/dib9000.c b/drivers/media/dvb/frontends/dib9000.c index 43fb6e4..9151876 100644 --- a/drivers/media/dvb/frontends/dib9000.c +++ b/drivers/media/dvb/frontends/dib9000.c @@ -486,10 +486,11 @@ static int dib9000_mbx_host_init(struct dib9000_state *state, u8 risc_id) #define MAX_MAILBOX_TRY 100 static int dib9000_mbx_send_attr(struct dib9000_state *state, u8 id, u16 * data, u8 len, u16 attr) { - u8 ret = 0, *d, b[2]; + u8 *d, b[2]; u16 tmp; u16 size; u32 i; + int ret = 0; if (!state->platform.risc.fw_is_running) return -EINVAL;