From patchwork Mon Jan 17 20:07:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Richter X-Patchwork-Id: 5615 Return-path: Envelope-to: mchehab@pedra Delivery-date: Mon, 17 Jan 2011 21:09:09 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1PeyCD-0005Qy-Di for mchehab@pedra; Mon, 17 Jan 2011 21:09:09 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 17 Jan 2011 21:09:09 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PevPh-00007E-52; Mon, 17 Jan 2011 20:10:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422Ab1AQUKq (ORCPT + 1 other); Mon, 17 Jan 2011 15:10:46 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:47523 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285Ab1AQUKq (ORCPT ); Mon, 17 Jan 2011 15:10:46 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Received: from stein ([83.221.231.7]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p0HKAX0o024094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 17 Jan 2011 21:10:33 +0100 Date: Mon, 17 Jan 2011 21:07:56 +0100 From: Stefan Richter To: Mauro Carvalho Chehab Cc: Dmitry Torokhov , linux-media@vger.kernel.org Subject: [PATCH incremental update] firedtv: fix remote control - addendum Message-ID: <20110117210756.510d4135@stein> In-Reply-To: <20110117170015.GA15404@core.coreip.homeip.net> References: <20110116093921.6275ac89@stein> <20110117081703.GA22802@core.coreip.homeip.net> <20110117141758.56af41f5@stein> <20110117170015.GA15404@core.coreip.homeip.net> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter --- Hi Mauro, since you already pushed out the first version of "firedtv: fix remote control with newer Xorg evdev", here is the differential patch to the updated version. It's surely not super urgent though. drivers/media/dvb/firewire/firedtv-rc.c | 1 + 1 file changed, 1 insertion(+) Index: b/drivers/media/dvb/firewire/firedtv-rc.c =================================================================== --- a/drivers/media/dvb/firewire/firedtv-rc.c +++ b/drivers/media/dvb/firewire/firedtv-rc.c @@ -190,6 +190,7 @@ void fdtv_handle_rc(struct firedtv *fdtv } input_report_key(idev, code, 1); + input_sync(idev); input_report_key(idev, code, 0); input_sync(idev); }