From patchwork Mon Jan 17 13:17:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Richter X-Patchwork-Id: 5610 Return-path: Envelope-to: mchehab@pedra Delivery-date: Mon, 17 Jan 2011 11:26:16 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1Pep68-0000xO-3d for mchehab@pedra; Mon, 17 Jan 2011 11:26:16 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 17 Jan 2011 11:26:15 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Peozw-0006H0-QQ; Mon, 17 Jan 2011 13:19:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714Ab1AQNTv (ORCPT + 1 other); Mon, 17 Jan 2011 08:19:51 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:42987 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210Ab1AQNTt (ORCPT ); Mon, 17 Jan 2011 08:19:49 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Received: from stein ([83.221.231.7]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p0HDJcuB019421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 17 Jan 2011 14:19:39 +0100 Date: Mon, 17 Jan 2011 14:17:58 +0100 From: Stefan Richter To: linux-media@vger.kernel.org Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux1394-devel@lists.sourceforge.net Subject: [PATCH update] firedtv: fix remote control with newer Xorg evdev Message-ID: <20110117141758.56af41f5@stein> In-Reply-To: <20110117081703.GA22802@core.coreip.homeip.net> References: <20110116093921.6275ac89@stein> <20110117081703.GA22802@core.coreip.homeip.net> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: After a recent update of xf86-input-evdev and xorg-server, I noticed that X11 applications did not receive keypresses from the FireDTV infrared remote control anymore. Instead, the Xorg log featured lots of "FireDTV remote control: dropping event due to full queue!" exclamations. The Linux console did not have an issue with the FireDTV's RC though. The fix is to insert EV_SYN events after the key-down/-up events. Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter Acked-by: Dmitry Torokhov --- drivers/media/dvb/firewire/firedtv-rc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: b/drivers/media/dvb/firewire/firedtv-rc.c =================================================================== --- a/drivers/media/dvb/firewire/firedtv-rc.c +++ b/drivers/media/dvb/firewire/firedtv-rc.c @@ -172,7 +172,8 @@ void fdtv_unregister_rc(struct firedtv * void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code) { - u16 *keycode = fdtv->remote_ctrl_dev->keycode; + struct input_dev *idev = fdtv->remote_ctrl_dev; + u16 *keycode = idev->keycode; if (code >= 0x0300 && code <= 0x031f) code = keycode[code - 0x0300]; @@ -188,6 +189,8 @@ void fdtv_handle_rc(struct firedtv *fdtv return; } - input_report_key(fdtv->remote_ctrl_dev, code, 1); - input_report_key(fdtv->remote_ctrl_dev, code, 0); + input_report_key(idev, code, 1); + input_sync(idev); + input_report_key(idev, code, 0); + input_sync(idev); }