From patchwork Mon Jan 17 12:21:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hans Verkuil (hansverk)" X-Patchwork-Id: 5609 Return-path: Envelope-to: mchehab@pedra Delivery-date: Mon, 17 Jan 2011 11:10:17 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1Peoqe-0006HH-Dy for mchehab@pedra; Mon, 17 Jan 2011 11:10:16 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 17 Jan 2011 11:10:16 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Peo61-00058M-Oi; Mon, 17 Jan 2011 12:22:06 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029Ab1AQMVz (ORCPT + 1 other); Mon, 17 Jan 2011 07:21:55 -0500 Received: from ams-iport-1.cisco.com ([144.254.224.140]:24238 "EHLO ams-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026Ab1AQMVy (ORCPT ); Mon, 17 Jan 2011 07:21:54 -0500 Authentication-Results: ams-iport-1.cisco.com; dkim=neutral (message not signed) header.i=none X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4GAK7DM02Q/khLgWdsb2JhbACWQ44XFQEBFiIkpzGYb4VQBIUthXKFMA Received: from ams-core-2.cisco.com ([144.254.72.75]) by ams-iport-1.cisco.com with ESMTP; 17 Jan 2011 12:21:53 +0000 Received: from cobaltpc1.localnet ([173.38.136.103]) by ams-core-2.cisco.com (8.14.3/8.14.3) with ESMTP id p0HCLrr5020862; Mon, 17 Jan 2011 12:21:53 GMT From: Hans Verkuil To: linux-media@vger.kernel.org Subject: [PATCH] Fix media_build file matching Date: Mon, 17 Jan 2011 13:21:15 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.32-23-generic; KDE/4.4.5; x86_64; ; ) Cc: "Mauro Carvalho Chehab" MIME-Version: 1.0 Message-Id: <201101171321.15893.hansverk@cisco.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Hi Mauro, Can you apply this patch to the media_build tree? It quotes the *.[ch] file pattern used by find. When I was experimenting with the media_build tree and trying 'make tar DIR=' I kept ending up with just one source in my tar archive. I couldn't for the life of me understand what was going on until I realized that I had a copy of a media driver source in the top dir of my git repository. Because the file pattern was not quoted it would expand to that particular source and match only that one. It took me a surprisingly long time before I figured this out :-( Quoting the pattern fixes this. Regards, Hans Signed-off-by: Hans Verkuil --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/linux/Makefile b/linux/Makefile index 8bbeee8..d731f61 100644 --- a/linux/Makefile +++ b/linux/Makefile @@ -58,7 +58,7 @@ todaytar: tar rvf $(PWD)/linux-media.tar git_log for i in $(TARDIR); do \ if [ "`echo $$i|grep Documentation`" = "" ]; then \ - dir="`(cd $(DIR); find $$i -type f -name *.[ch])`"; \ + dir="`(cd $(DIR); find $$i -type f -name '*.[ch]')`"; \ dir="$$dir `(cd $(DIR); find $$i -type f -name Makefile)`"; \ dir="$$dir `(cd $(DIR); find $$i -type f -name Kconfig)`"; \ tar rvf $(PWD)/$(TODAY_TAR) -C $(DIR) $$dir; \ @@ -75,7 +75,7 @@ tar: tar rvf $(PWD)/linux-media.tar git_log for i in $(TARDIR); do \ if [ "`echo $$i|grep Documentation`" = "" ]; then \ - dir="`(cd $(DIR); find $$i -type f -name *.[ch])`"; \ + dir="`(cd $(DIR); find $$i -type f -name '*.[ch]')`"; \ dir="$$dir `(cd $(DIR); find $$i -type f -name Makefile)`"; \ dir="$$dir `(cd $(DIR); find $$i -type f -name Kconfig)`"; \ tar rvf $(PWD)/linux-media.tar -C $(DIR) $$dir; \