From patchwork Tue Nov 2 16:14:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 4782 Return-path: Envelope-to: mchehab@gaivota Delivery-date: Tue, 02 Nov 2010 14:22:59 -0400 Received: from mchehab by gaivota with local (Exim 4.72) (envelope-from ) id 1PDLVb-0000rp-Ml for mchehab@gaivota; Tue, 02 Nov 2010 14:22:59 -0400 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.17) for (single-drop); Tue, 02 Nov 2010 14:22:59 -0400 (EDT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PDJVu-00085F-7e; Tue, 02 Nov 2010 16:15:10 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732Ab0KBQPI (ORCPT + 1 other); Tue, 2 Nov 2010 12:15:08 -0400 Received: from d1.icnet.pl ([212.160.220.21]:35736 "EHLO d1.icnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596Ab0KBQPH (ORCPT ); Tue, 2 Nov 2010 12:15:07 -0400 Received: from 87-205-12-81.ip.netia.com.pl ([87.205.12.81] helo=vclass.intranet) by d1.icnet.pl with asmtp (TLS-1.0:DHE_RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1PDJVq-0006xC-At; Tue, 02 Nov 2010 17:15:06 +0100 From: Janusz Krzysztofik Organization: Tele-Info-System, Poznan, PL To: Guennadi Liakhovetski Subject: [PATCH] SoC Camera: ov6650: minor cleanups Date: Tue, 2 Nov 2010 17:14:36 +0100 User-Agent: KMail/1.9.10 Cc: Linux Media Mailing List MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201011021714.37544.jkrzyszt@tis.icnet.pl> X-SA-Exim-Scanned: No (on d1.icnet); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab This is a followup patch that addresses two minor issues left in the recently added ov6650 sensor driver, as I've promised to the subsystem maintainer: - remove a pair of extra brackets, - drop useless case for not possible v4l2_mbus_pixelcode enum value of 0. Created against linux-2.6.37-rc1. Signed-off-by: Janusz Krzysztofik --- drivers/media/video/ov6650.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.37-rc1/drivers/media/video/ov6650.c.orig 2010-11-01 22:41:59.000000000 +0100 +++ linux-2.6.37-rc1/drivers/media/video/ov6650.c 2010-11-02 16:56:49.000000000 +0100 @@ -754,7 +754,7 @@ static int ov6650_g_fmt(struct v4l2_subd static bool is_unscaled_ok(int width, int height, struct v4l2_rect *rect) { - return (width > rect->width >> 1 || height > rect->height >> 1); + return width > rect->width >> 1 || height > rect->height >> 1; } static u8 to_clkrc(struct v4l2_fract *timeperframe, @@ -840,8 +840,6 @@ static int ov6650_s_fmt(struct v4l2_subd coma_mask |= COMA_BW | COMA_BYTE_SWAP | COMA_WORD_SWAP; coma_set |= COMA_RAW_RGB | COMA_RGB; break; - case 0: - break; default: dev_err(&client->dev, "Pixel format not handled: 0x%x\n", code); return -EINVAL;