From patchwork Thu Oct 21 19:24:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 4689 Return-path: Envelope-to: mchehab@pedra Delivery-date: Thu, 21 Oct 2010 18:56:40 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1P92Bj-00052i-NL for mchehab@pedra; Thu, 21 Oct 2010 18:56:40 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Thu, 21 Oct 2010 18:56:39 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P90kj-0007Vd-7W; Thu, 21 Oct 2010 19:24:41 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757815Ab0JUTYj (ORCPT + 1 other); Thu, 21 Oct 2010 15:24:39 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:47854 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755768Ab0JUTYi (ORCPT ); Thu, 21 Oct 2010 15:24:38 -0400 Received: by ewy7 with SMTP id 7so20233ewy.19 for ; Thu, 21 Oct 2010 12:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=PhdLhigcKEck2XRlSni3oCLJiN29p83zbP9wFTN/XRs=; b=sZQ77U5VyjX6QIUgSzbOYiCQ8wibmIHgkQAL/N+8Cg6em/YW6G7Df3EdgOIt93ai1J lbawDjEB/xBMU4j3MAa2baI1bsPvkm6et28J3JMkgD/HSW+A9xoqD4N/4idmZKGE1a1Z NwAd6sFwKPTCErhqRuaHfEqIvhboaLekfL8Dc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=u3ITtW39QKE8HWLjOW4NDRugqz6Bj0ysT8j0mKIJlx7kPbdcp/+N6pq6Ceyt9gwCMn LU4OhVqRatYbmhG92Z0ugVJGYQy4YIfr4dFJ4/ntPji16Pc562OvQaGLIAuQvmN2uLXJ VwYi1is/xANH04ei8JWf/KWJSpcYThOJOZ9T4= Received: by 10.216.82.197 with SMTP id o47mr1473492wee.45.1287689076102; Thu, 21 Oct 2010 12:24:36 -0700 (PDT) Received: from bicker (h3f03.n1.ips.mtn.co.ug [41.210.191.3]) by mx.google.com with ESMTPS id e56sm1310270wer.22.2010.10.21.12.24.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 21 Oct 2010 12:24:35 -0700 (PDT) Date: Thu, 21 Oct 2010 21:24:24 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Kyungmin Park , Sylwester Nawrocki , Pawel Osciak , Marek Szyprowski , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields Message-ID: <20101021192424.GL5985@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: These are signed so instead of being 1 and 0 as intended they are -1 and 0. It doesn't cause a bug in the current code but Sparse warns about it: drivers/media/video/s5p-fimc/fimc-core.h:226:28: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h index e3a7c6a..7665a3f 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.h +++ b/drivers/media/video/s5p-fimc/fimc-core.h @@ -222,10 +223,10 @@ struct fimc_effect { * @real_height: source pixel (height - offset) */ struct fimc_scaler { - int scaleup_h:1; - int scaleup_v:1; - int copy_mode:1; - int enabled:1; + unsigned int scaleup_h:1; + unsigned int caleup_v:1; + unsigned int copy_mode:1; + unsigned int enabled:1; u32 hfactor; u32 vfactor; u32 pre_hratio;