From patchwork Thu Oct 21 19:22:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 4687 Return-path: Envelope-to: mchehab@pedra Delivery-date: Thu, 21 Oct 2010 18:56:27 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1P92BW-00051s-KY for mchehab@pedra; Thu, 21 Oct 2010 18:56:26 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Thu, 21 Oct 2010 18:56:26 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P90ia-0007Rg-6B; Thu, 21 Oct 2010 19:22:28 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757642Ab0JUTWZ (ORCPT + 1 other); Thu, 21 Oct 2010 15:22:25 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:59563 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755772Ab0JUTWZ (ORCPT ); Thu, 21 Oct 2010 15:22:25 -0400 Received: by wwe15 with SMTP id 15so105453wwe.1 for ; Thu, 21 Oct 2010 12:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=7ctq3hONBs81wuAe0cDc40tlay9JwYUF9b/1DzLaSYo=; b=Jfs71SexptcjBDiwvajPtWMkmwDGukxGyWNCMpVFg0fsCKjHAtYe2Sr4GLvZY7i8S6 YKB6R24LTFwoqztmTULeAHXJvEEoVj3OECFuNulbDmyClVYQ3ogbt6AoYcYy54o7jHaK 87CJtQhSnmuIoOZr34vCv6nse2TadUp2n6Mkg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=tMynCO63GBRfVTdapn1wQQ5C0WGr/wfzLeHSaAVNZUnCTCqyI5199hvNpQ16b3HQrn zFfvS02FVJwtdVxgGtd3xHlEcmq+YUJaRmH2fBE5cDPFQiupF0N4ulWov8dmJbnlVNZj WSiCelZd+Zsok9JEvmgONA7Bo+Xbx0//SFVR0= Received: by 10.227.133.84 with SMTP id e20mr1730338wbt.10.1287688943446; Thu, 21 Oct 2010 12:22:23 -0700 (PDT) Received: from bicker (h3f03.n1.ips.mtn.co.ug [41.210.191.3]) by mx.google.com with ESMTPS id h29sm1643173wbc.9.2010.10.21.12.22.19 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 21 Oct 2010 12:22:22 -0700 (PDT) Date: Thu, 21 Oct 2010 21:22:14 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Devin Heitmueller , Palash Bandyopadhyay , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] V4L/DVB: cx231xx: fix double lock typo Message-ID: <20101021192214.GI5985@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: This was supposed to be an unlock on the error path. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/video/cx231xx/cx231xx-i2c.c index cce74e5..8356706 100644 --- a/drivers/media/video/cx231xx/cx231xx-i2c.c +++ b/drivers/media/video/cx231xx/cx231xx-i2c.c @@ -372,7 +372,7 @@ static int cx231xx_i2c_xfer(struct i2c_adapter *i2c_adap, rc = cx231xx_i2c_check_for_device(i2c_adap, &msgs[i]); if (rc < 0) { dprintk2(2, " no device\n"); - mutex_lock(&dev->i2c_lock); + mutex_unlock(&dev->i2c_lock); return rc; }