From patchwork Thu Aug 19 09:47:50 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 4218 Return-path: Envelope-to: mchehab@pedra Delivery-date: Thu, 19 Aug 2010 07:05:18 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1Om1zq-0006SM-Fk for mchehab@pedra; Thu, 19 Aug 2010 07:05:18 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Thu, 19 Aug 2010 07:05:18 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Om1k5-0000de-ED; Thu, 19 Aug 2010 09:49:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138Ab0HSJtA (ORCPT + 1 other); Thu, 19 Aug 2010 05:49:00 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:33594 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133Ab0HSJs6 (ORCPT ); Thu, 19 Aug 2010 05:48:58 -0400 Received: by wwi17 with SMTP id 17so2214526wwi.1 for ; Thu, 19 Aug 2010 02:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=gFFBAqmoaAoKlK0tVGiBogRlcLQTRSyRNl58TRSJFio=; b=Gll77mJUonGjHb6nkuXUFntFCJXTFLf7Fq6w02sdIgKBmd4tQ1WjHqJ8v1g34Mn2Sp /FbweF4RSNrdSzqPHW8Z7x4QPJwFM8pHvvmJ/0xBFmK+OfVDaAekt/JA/HU+bfKE4kdm Rse2RlU3qygkIbY2Bjt6PzgPKrsGR6oh9Dm7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=oxvvDMOywuwjIzNRx8gCxokByRH0Khc+5Bm7vhkeHs/8UM6V1PgkLTUNgJVp0qMzeo 5qQx/zfm91d2Wtbomix8w5srmmVqdAHGo1PGdka7IaMZtd1i3t3Yb5VnxLavSDu2HcrX hSzLrNqdakIjGeCHLFbmydITYdjwCHDAzW60Y= Received: by 10.227.127.149 with SMTP id g21mr7815964wbs.218.1282211337052; Thu, 19 Aug 2010 02:48:57 -0700 (PDT) Received: from bicker ([41.205.146.22]) by mx.google.com with ESMTPS id m25sm1178740wbc.13.2010.08.19.02.48.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 19 Aug 2010 02:48:56 -0700 (PDT) Date: Thu, 19 Aug 2010 11:47:50 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] V4L/DVB: opera1: remove unneeded NULL check Message-ID: <20100819094750.GM645@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab "fw" is always a non-NULL pointer at this point, and anyway release_firmware() accepts NULL pointers. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/dvb/dvb-usb/opera1.c b/drivers/media/dvb/dvb-usb/opera1.c index 6b22ec6..f896337 100644 --- a/drivers/media/dvb/dvb-usb/opera1.c +++ b/drivers/media/dvb/dvb-usb/opera1.c @@ -483,9 +483,7 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev, } } kfree(p); - if (fw) { - release_firmware(fw); - } + release_firmware(fw); return ret; }