From patchwork Fri Aug 6 06:31:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 4095 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Fri, 06 Aug 2010 06:31:34 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Fri, 06 Aug 2010 09:07:49 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OhGSs-0001b9-4k; Fri, 06 Aug 2010 06:31:34 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754998Ab0HFGbc (ORCPT + 1 other); Fri, 6 Aug 2010 02:31:32 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:39269 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900Ab0HFGbb (ORCPT ); Fri, 6 Aug 2010 02:31:31 -0400 Received: by wyb39 with SMTP id 39so7432880wyb.19 for ; Thu, 05 Aug 2010 23:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=DlLC0y/6nBi+e3voOfAExSH/U9dMOJSvTE/eBDxFHhg=; b=oZvub3HW0E6xN7h45RvUXKYqxULYazGCMAACQGio6o2qrare9Kj772RB86ccnfGYzo hJwhZ+l574I6xSx/p1PLf0Vh+fU2g9yPU8H1qPRHQruL5u+Zvbu1jTotDaNoafu/uCW/ Ab6wJCs/aIlt3/LjjqEiKLiiGAGNWcjkZkzo4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=MQArvePF7My66pYnl2f1ul/IS4d0IP+JtYOrICAEahQxSolARJ23GWXA6RKY9XSuxr P12yJeIWEwirp9R60viVwiJLkcKvqU1HvFGtvLQtZvz8eh1VSI5MQxeURl+O6M0w87CT h/uJESbPXM5j5VvFRcwV5qqe1MVkLI4oqEx3Q= Received: by 10.227.128.4 with SMTP id i4mr10121167wbs.106.1281076289538; Thu, 05 Aug 2010 23:31:29 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id h3sm1002947wbb.15.2010.08.05.23.31.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 05 Aug 2010 23:31:28 -0700 (PDT) Date: Fri, 6 Aug 2010 08:31:00 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: David =?iso-8859-1?Q?H=E4rdeman?= , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] media: ir-keytable: null dereference in debug code Message-ID: <20100806063059.GN9031@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org "ir_dev->props" can be NULL. We only use raw mode if "ir_dev->props" is non-NULL and "ir_dev->props->driver_type == RC_DRIVER_IR_RAW". Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 15a0f19..cf97427 100644 --- a/drivers/media/IR/ir-keytable.c +++ b/drivers/media/IR/ir-keytable.c @@ -499,7 +499,8 @@ int __ir_input_register(struct input_dev *input_dev, IR_dprintk(1, "Registered input device on %s for %s remote%s.\n", driver_name, rc_tab->name, - ir_dev->props->driver_type == RC_DRIVER_IR_RAW ? " in raw mode" : ""); + (ir_dev->props && ir_dev->props->driver_type == RC_DRIVER_IR_RAW) ? + " in raw mode" : ""); return 0;