From patchwork Fri Jul 23 10:08:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 3873 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Fri, 23 Jul 2010 10:08:55 +0000 Received: from bombadil.infradead.org [18.85.46.34] by localhost with IMAP (fetchmail-6.3.17) for (single-drop); Fri, 23 Jul 2010 10:37:23 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OcFBX-0006zL-Gg; Fri, 23 Jul 2010 10:08:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755671Ab0GWKIr (ORCPT + 1 other); Fri, 23 Jul 2010 06:08:47 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:51690 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435Ab0GWKIp (ORCPT ); Fri, 23 Jul 2010 06:08:45 -0400 Received: by fxm14 with SMTP id 14so4897338fxm.19 for ; Fri, 23 Jul 2010 03:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=hLH49Tc7uK6x4A2NsnHEsHnjKHeigysPZNSQqHnflRo=; b=rqn0GykXKm3CfhzS/VUM4LeW9YwmgxBFJp9WdtJetXI2pV6iaJnfyCXWlv8WvnqYkh ZnSSQbNXJa/Vi/xqBXEfUG2RR/l5FW6ydd1Z475lb83pHuI+g9tBQbqJVnxL2Bo6fPLl TT3B+YU21Kzjm0lqva0wWehPyCg8c5HBPyDr8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=RQPlS9CXMnu9tiIXSTx1hMo70RxLFIlHBTJ8OALq1xHT6Q/u00Vap0A1e1n+RHMcaB e1CZmfNulW6Lod0830QD0LXZWkFKDzFOf8VwOZorkeras8EnE13Fogcb/5UrBl//sAIE Mfvz0GhOUKJ3NuV0sbl/0ocPJlvLcYq+lvM7M= Received: by 10.86.57.1 with SMTP id f1mr2492063fga.54.1279879724522; Fri, 23 Jul 2010 03:08:44 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id r8sm27862faq.10.2010.07.23.03.08.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 23 Jul 2010 03:08:43 -0700 (PDT) Date: Fri, 23 Jul 2010 12:08:26 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Jarod Wilson , Arnd Bergmann , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] V4L: media/IR: testing the wrong variable Message-ID: <20100723100826.GB26313@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is a typo here. We meant to test "rbuf" instead of "drv". We already tested "drv" earlier. Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c index 178bc5b..870000e 100644 --- a/drivers/media/IR/ir-lirc-codec.c +++ b/drivers/media/IR/ir-lirc-codec.c @@ -192,7 +192,7 @@ static int ir_lirc_register(struct input_dev *input_dev) return rc; rbuf = kzalloc(sizeof(struct lirc_buffer), GFP_KERNEL); - if (!drv) + if (!rbuf) goto rbuf_alloc_failed; rc = lirc_buffer_init(rbuf, sizeof(int), LIRCBUF_SIZE);