From patchwork Tue May 4 11:38:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 3294 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 04 May 2010 11:38:35 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Tue, 04 May 2010 09:27:46 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O9GSR-0006ve-Fl; Tue, 04 May 2010 11:38:35 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757396Ab0EDLie (ORCPT + 1 other); Tue, 4 May 2010 07:38:34 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:39657 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752058Ab0EDLid (ORCPT ); Tue, 4 May 2010 07:38:33 -0400 Received: by fxm10 with SMTP id 10so3101534fxm.19 for ; Tue, 04 May 2010 04:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=HfwcZBtmfo8XQA9cjPk4X2uxTi/ckBNZQmpEpYTtumc=; b=BvaLQhwGqcesD6u1/FjuoddfstiJv0hPNON9cDmdsk4BLbYCVeQ77+QBA98jLZG9lF AcjnPIZzTUuahWQ+/kvynkpwWysExuQGOxKVfcAxpUynH9flz9Vb+jQzRNz2ugj9YIKf R4mpg3ogDwxHxQX25EpaGt3cAsM5duUlL5IjE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=xl/C/6DTde0I/swnJEffnstAK6uqNJGewFw1ILYGbLrXTC5bFwpgXwA3aSjo+bdFMS +fQqE8vOcq5DKFS33ADr7SBqcZAmEEl+0O/yTIGvVkOzOv/3H9aeiuFSnTjO2rxch+qT WyS0s3Hiaaospdy1vXs8yausGMiPWM7MN7qHI= Received: by 10.223.98.19 with SMTP id o19mr4073850fan.80.1272973112469; Tue, 04 May 2010 04:38:32 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id 21sm11113641fkx.10.2010.05.04.04.38.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 May 2010 04:38:32 -0700 (PDT) Date: Tue, 4 May 2010 13:38:26 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Jarod Wilson , linux-media@vger.kernel.org Subject: [patch -next 2/3] media/IR/imon: testing the wrong variable Message-ID: <20100504113825.GV29093@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is a typo here. We meant to test "ir" instead of "props". The "props" variable was tested earlier. Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b65c31a..f2066d0 100644 --- a/drivers/media/IR/imon.c +++ b/drivers/media/IR/imon.c @@ -1672,7 +1672,7 @@ static struct input_dev *imon_init_idev(struct imon_context *ictx) } ir = kzalloc(sizeof(struct ir_input_dev), GFP_KERNEL); - if (!props) { + if (!ir) { dev_err(ictx->dev, "remote ir input dev allocation failed\n"); goto ir_dev_alloc_failed; }