From patchwork Tue May 4 11:36:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 3292 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 04 May 2010 11:36:47 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Tue, 04 May 2010 09:27:44 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O9GQh-0006p6-6g; Tue, 04 May 2010 11:36:47 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756225Ab0EDLgp (ORCPT + 1 other); Tue, 4 May 2010 07:36:45 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:58798 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752058Ab0EDLgp (ORCPT ); Tue, 4 May 2010 07:36:45 -0400 Received: by fxm10 with SMTP id 10so3099898fxm.19 for ; Tue, 04 May 2010 04:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=nMwEj0waoIuYyUaTMqJkjPG0HQAZHkUl7QB95lx1uSk=; b=s9UMQc63yQp+BpNvQFo2+c01NZhpDrPv/x4UrJdXbhOOE6JnwOQBwWD472aOwI6gHP b2s3x1N+ruuz04M4QnBLkqU+8D8K1/tL/KGz6X8lLVFZ0Yp0gofeeSc/B4Q2sjH8MkO3 jngbWuTMNUBmxXq3rdZou0KXTIw/zHGv0vdPY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=nUpGvPRflS5Z2+Yhvg9038ZX1ugvBFu+gjeiF+42ubwuJ8Y1dJ2lw63d1zfp5xIlg4 /TBdwcoC7sarI/EynFYI5OmsVh5rt1VBvSNEjlZeSYXhtPrTvpU3SIgxb7l/c4ezeEzy SWe1YhkQWbw6lYJf9rRusMeMAVFHHrlEfLKLU= Received: by 10.223.33.218 with SMTP id i26mr3901574fad.58.1272973003242; Tue, 04 May 2010 04:36:43 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id 26sm11101090fks.52.2010.05.04.04.36.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 May 2010 04:36:42 -0700 (PDT) Date: Tue, 4 May 2010 13:36:34 +0200 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Jarod Wilson , linux-media@vger.kernel.org Subject: [patch -next 3/3] media/IR/imon: potential double unlock on error Message-ID: <20100504113634.GT29093@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org If there is an error here we should unlock in the caller (which is imon_init_intf1()). We can remove this stray unlock. Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b65c31a..d48ad6d 100644 --- a/drivers/media/IR/imon.c +++ b/drivers/media/IR/imon.c @@ -1777,7 +1777,6 @@ static struct input_dev *imon_init_touch(struct imon_context *ictx) touch_register_failed: input_free_device(ictx->touch); - mutex_unlock(&ictx->lock); touch_alloc_failed: return NULL;