From patchwork Tue Mar 23 11:40:43 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 2999 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 23 Mar 2010 11:41:15 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Tue, 23 Mar 2010 10:19:53 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Nu2Ty-0007Tn-Tk; Tue, 23 Mar 2010 11:41:15 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656Ab0CWLkz (ORCPT + 1 other); Tue, 23 Mar 2010 07:40:55 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:3971 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab0CWLkx (ORCPT ); Tue, 23 Mar 2010 07:40:53 -0400 Received: by fg-out-1718.google.com with SMTP id 19so958226fgg.1 for ; Tue, 23 Mar 2010 04:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=O5VZqPOjfSyZtpyMm4jrAl3lOZLDbLVIo2BYA8TG8tk=; b=gQ0Fba9ikJnu2AF+bc3GL5ebZpECQSVXkvlPQ0+Wt07ITguw/AMemMqcDGtGpmFy9T ShFhbEAbBftRatMETp9PfGkqibf8PfjK3kkwYvkcd5kKzo7WAtRHG5r+2hQIVgmuAC/q GsuqHqYEAB5k4w1XPhGAsgfFe5dK0uwP4TjmU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=YEQz930Cm3tgZxZlztzCgPLYff98gZ8vu+SP3SK9KTVY8fH4s4mtF3T2oxnRhePS2B mGmxoViykw/CNdO8VZk/01FDqvUfaoI+Jn3qIC7bKfyLGRNVkCnGL5DFIrGAiUoekN2d TdAq7GJNz34SGD89GHIWmuwzRiFeqrcPZ9bp4= Received: by 10.204.34.201 with SMTP id m9mr1814440bkd.118.1269344452070; Tue, 23 Mar 2010 04:40:52 -0700 (PDT) Received: from bicker ([196.43.68.160]) by mx.google.com with ESMTPS id x16sm25294721bku.17.2010.03.23.04.40.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 23 Mar 2010 04:40:51 -0700 (PDT) Date: Tue, 23 Mar 2010 14:40:43 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab , Douglas Schilling Landgraf , Robert Krakora , Nicola Soranzo , Devin Heitmueller , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Andrew Morton Subject: [patch v2] em28xx: "Empia Em28xx Audio" too long Message-ID: <20100323114043.GY21571@bicker> Mail-Followup-To: Dan Carpenter , Mauro Carvalho Chehab , Douglas Schilling Landgraf , Robert Krakora , Nicola Soranzo , Devin Heitmueller , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Andrew Morton References: <20100319114825.GO5331@bicker> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100319114825.GO5331@bicker> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org card->driver is 15 characters and a NULL. The original code goes past the end of the array. Signed-off-by: Dan Carpenter --- V2: Takashi Iwai asked me to change the space to a hyphen since this is used as an identifier in alsa-lib. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index bd78338..e182abf 100644 --- a/drivers/media/video/em28xx/em28xx-audio.c +++ b/drivers/media/video/em28xx/em28xx-audio.c @@ -491,7 +491,7 @@ static int em28xx_audio_init(struct em28xx *dev) strcpy(pcm->name, "Empia 28xx Capture"); snd_card_set_dev(card, &dev->udev->dev); - strcpy(card->driver, "Empia Em28xx Audio"); + strcpy(card->driver, "Em28xx-Audio"); strcpy(card->shortname, "Em28xx Audio"); strcpy(card->longname, "Empia Em28xx Audio");