From patchwork Fri Mar 19 11:49:57 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 2972 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Fri, 19 Mar 2010 11:50:35 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Fri, 19 Mar 2010 08:54:35 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Nsaio-0005H8-S0; Fri, 19 Mar 2010 11:50:35 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986Ab0CSLuK (ORCPT + 1 other); Fri, 19 Mar 2010 07:50:10 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:56642 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110Ab0CSLuI (ORCPT ); Fri, 19 Mar 2010 07:50:08 -0400 Received: by bwz1 with SMTP id 1so2872264bwz.21 for ; Fri, 19 Mar 2010 04:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mail-followup-to:mime-version:content-type :content-disposition:user-agent; bh=o78djqSjVO6G5ZQpr6jhzDrUTXuYU9Uhs2C46oUE/nA=; b=W8u/wlhpbBj59JhKu9Bd9OSh0jCQYgfkyrlngYTpxQFuiiLpaMFlCGLlFrkrnjHAgf 8p5GYxfAM9AwdWC0ZyotG2EV04HNJAZFDD3Hd18o0RsdzQoieDwrIwIaUEMfAH+JV1db RwyJojmUPQCXP2/a/kFWlPOT01StcRF2cLWRg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=epYgaTQZQNqutQkLl4da2xHLcDB2k1BiNygnAu6gZJomnLUXy8dLu+0T1aaelNih2Q ppW+u/s4pRV/Prckt/W1VN0PaVY0i3k3mKaG0Ef1miJNzdMLz4TSSPLZPqoCkUEUA67+ CMnrDD9BLfkOl3hljPF1kFdf7ouGVRa4/JyEw= Received: by 10.204.174.194 with SMTP id u2mr1505738bkz.40.1268999405373; Fri, 19 Mar 2010 04:50:05 -0700 (PDT) Received: from bicker ([196.43.68.18]) by mx.google.com with ESMTPS id 24sm4260560bkr.0.2010.03.19.04.50.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 04:50:04 -0700 (PDT) Date: Fri, 19 Mar 2010 14:49:57 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Srinivasa Deevi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] cx231xx: card->driver "Conexant cx231xx Audio" too long Message-ID: <20100319114957.GQ5331@bicker> Mail-Followup-To: Dan Carpenter , Mauro Carvalho Chehab , Srinivasa Deevi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org card->driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c index 7793d60..b3282ae 100644 --- a/drivers/media/video/cx231xx/cx231xx-audio.c +++ b/drivers/media/video/cx231xx/cx231xx-audio.c @@ -495,7 +495,7 @@ static int cx231xx_audio_init(struct cx231xx *dev) pcm->info_flags = 0; pcm->private_data = dev; strcpy(pcm->name, "Conexant cx231xx Capture"); - strcpy(card->driver, "Conexant cx231xx Audio"); + strcpy(card->driver, "Cx231xx Audio"); strcpy(card->shortname, "Cx231xx Audio"); strcpy(card->longname, "Conexant cx231xx Audio");