From patchwork Tue Nov 17 22:43:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 2086 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 17 Nov 2009 22:44:37 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Tue, 17 Nov 2009 20:51:56 -0200 (BRST) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NAWmr-0004sg-Jb; Tue, 17 Nov 2009 22:44:37 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302AbZKQWoU (ORCPT + 1 other); Tue, 17 Nov 2009 17:44:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756572AbZKQWoM (ORCPT ); Tue, 17 Nov 2009 17:44:12 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59991 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756443AbZKQWoL (ORCPT ); Tue, 17 Nov 2009 17:44:11 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id nAHMhf9e016255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 Nov 2009 14:43:42 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id nAHMheaR029255; Tue, 17 Nov 2009 14:43:40 -0800 Message-Id: <200911172243.nAHMheaR029255@imap1.linux-foundation.org> Subject: [patch 4/5] sms-cards: make id unsigned in sms_get_board() To: mchehab@infradead.org Cc: linux-media@vger.kernel.org, akpm@linux-foundation.org, roel.kluin@gmail.com, mkrufky@kernellabs.com From: akpm@linux-foundation.org Date: Tue, 17 Nov 2009 14:43:40 -0800 MIME-Version: 1.0 X-Spam-Status: No, hits=-3.518 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Roel Kluin Make id signed so we can't get an invalid pointer when we pass a negative id. Signed-off-by: Roel Kluin Cc: Mauro Carvalho Chehab Cc: Michael Krufky Signed-off-by: Andrew Morton --- drivers/media/dvb/siano/sms-cards.c | 2 +- drivers/media/dvb/siano/sms-cards.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/media/dvb/siano/sms-cards.c~sms-cards-make-id-unsigned-in-sms_get_board drivers/media/dvb/siano/sms-cards.c --- a/drivers/media/dvb/siano/sms-cards.c~sms-cards-make-id-unsigned-in-sms_get_board +++ a/drivers/media/dvb/siano/sms-cards.c @@ -97,7 +97,7 @@ static struct sms_board sms_boards[] = { }, }; -struct sms_board *sms_get_board(int id) +struct sms_board *sms_get_board(unsigned id) { BUG_ON(id >= ARRAY_SIZE(sms_boards)); diff -puN drivers/media/dvb/siano/sms-cards.h~sms-cards-make-id-unsigned-in-sms_get_board drivers/media/dvb/siano/sms-cards.h --- a/drivers/media/dvb/siano/sms-cards.h~sms-cards-make-id-unsigned-in-sms_get_board +++ a/drivers/media/dvb/siano/sms-cards.h @@ -81,7 +81,7 @@ struct sms_board { int led_power, led_hi, led_lo, lna_ctrl, rf_switch; }; -struct sms_board *sms_get_board(int id); +struct sms_board *sms_get_board(unsigned id); extern struct smscore_device_t *coredev;