From patchwork Tue Nov 10 12:48:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 2039 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 10 Nov 2009 12:49:41 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Tue, 10 Nov 2009 11:38:26 -0200 (BRST) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N7qAG-0004HT-O7; Tue, 10 Nov 2009 12:49:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750912AbZKJMtd (ORCPT + 1 other); Tue, 10 Nov 2009 07:49:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751029AbZKJMtd (ORCPT ); Tue, 10 Nov 2009 07:49:33 -0500 Received: from smtp-out13.alice.it ([85.33.2.18]:3147 "EHLO smtp-out13.alice.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbZKJMtc (ORCPT ); Tue, 10 Nov 2009 07:49:32 -0500 Received: from FBCMMO05.fbc.local ([192.168.184.136]) by smtp-out13.alice.it with Microsoft SMTPSVC(6.0.3790.3959); Tue, 10 Nov 2009 13:49:38 +0100 Received: from FBCMCL01B03.fbc.local ([192.168.69.84]) by FBCMMO05.fbc.local with Microsoft SMTPSVC(6.0.3790.3959); Tue, 10 Nov 2009 13:48:48 +0100 Received: from badebec ([82.57.80.112]) by FBCMCL01B03.fbc.local with Microsoft SMTPSVC(6.0.3790.3959); Tue, 10 Nov 2009 13:48:47 +0100 Date: Tue, 10 Nov 2009 13:48:37 +0100 From: Antonio Ospite To: Eric Miao Cc: linux-arm-kernel@lists.infradead.org, openezx-devel@lists.openezx.org, Bart Visscher , linux-media@vger.kernel.org, Guennadi Liakhovetski Subject: Re: [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones Message-Id: <20091110134837.207bb92a.ospite@studenti.unina.it> In-Reply-To: References: <1257266734-28673-1-git-send-email-ospite@studenti.unina.it> <1257266734-28673-2-git-send-email-ospite@studenti.unina.it> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.3; i686-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM/Vb; ]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 X-OriginalArrivalTime: 10 Nov 2009 12:48:47.0128 (UTC) FILETIME=[24DC2980:01CA6204] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 4 Nov 2009 14:38:40 +0800 Eric Miao wrote: > Hi Antonio, > > Patch looks generally OK except for the MFP/GPIO usage... Eric, while I was at it I also checked the original code Motorola released. It has: PGSR(GPIO_CAM_EN) |= GPIO_bit(GPIO_CAM_EN); PGSR(GPIO_CAM_RST)|= GPIO_bit(GPIO_CAM_RST); After checking PXA manual and arch/arm/mach-pxa/mfp-pxa2xx.c, I'd translate this to: Is that right? I am putting also this into the next version I am going to send for submission, if you don't object. Thanks, Antonio diff --git a/arch/arm/mach-pxa/ezx.c b/arch/arm/mach-pxa/ezx.c index 77286a2..6a47a9d 100644 --- a/arch/arm/mach-pxa/ezx.c +++ b/arch/arm/mach-pxa/ezx.c @@ -281,8 +281,8 @@ static unsigned long gen1_pin_config[] __initdata = { GPIO94_CIF_DD_5, GPIO17_CIF_DD_6, GPIO108_CIF_DD_7, - GPIO50_GPIO, /* CAM_EN */ - GPIO19_GPIO, /* CAM_RST */ + GPIO50_GPIO | MFP_LPM_DRIVE_HIGH, /* CAM_EN */ + GPIO19_GPIO | MFP_LPM_DRIVE_HIGH, /* CAM_RST */ /* EMU */ GPIO120_GPIO, /* EMU_MUX1 */ @@ -338,8 +338,8 @@ static unsigned long gen2_pin_config[] __initdata = { GPIO48_CIF_DD_5, GPIO93_CIF_DD_6, GPIO12_CIF_DD_7, - GPIO50_GPIO, /* CAM_EN */ - GPIO28_GPIO, /* CAM_RST */ + GPIO50_GPIO | MFP_LPM_DRIVE_HIGH, /* CAM_EN */ + GPIO28_GPIO | MFP_LPM_DRIVE_HIGH, /* CAM_RST */ GPIO17_GPIO, /* CAM_FLASH */ }; #endif