From patchwork Mon Jun 22 14:36:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schwarzott X-Patchwork-Id: 1686 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 22 Jun 2009 14:36:53 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Mon, 22 Jun 2009 11:41:05 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MIkdg-0006Aw-TF; Mon, 22 Jun 2009 14:36:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756959AbZFVOga (ORCPT + 1 other); Mon, 22 Jun 2009 10:36:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756557AbZFVOg3 (ORCPT ); Mon, 22 Jun 2009 10:36:29 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:47791 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756864AbZFVOg2 (ORCPT ); Mon, 22 Jun 2009 10:36:28 -0400 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 44A621C000B0 for ; Mon, 22 Jun 2009 16:36:31 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id 3F848903CD for ; Mon, 22 Jun 2009 16:36:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id SFjhWBT7ui4W for ; Mon, 22 Jun 2009 16:36:26 +0200 (CEST) Received: from gauss.x.fun (ppp-88-217-107-241.dynamic.mnet-online.de [88.217.107.241]) by mail.nefkom.net (Postfix) with ESMTP for ; Mon, 22 Jun 2009 16:36:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by gauss.x.fun (Postfix) with ESMTP id EE0001FC9AA for ; Mon, 22 Jun 2009 16:36:25 +0200 (CEST) From: Matthias Schwarzott To: linux-media@vger.kernel.org Subject: lsmod path hardcoded in v4l/Makefile Date: Mon, 22 Jun 2009 16:36:24 +0200 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <200906221636.25006.zzam@gentoo.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi list! It seems the path to lsmod tool is hardcoded in the Makefile for out-of-tree building of v4l-dvb. Now at least gentoo has moved lsmod from /sbin to /bin. Additionally it is bad style (or at least I am told so), to not rely on $PATH but hardcode pathes for tools that should be in $PATH. So the attached patch removes the hardcoded /sbin from the lsmod call. Signed-off-by: Matthias Schwarzott Regards Matthias diff -r 65ec132f20df v4l/Makefile --- a/v4l/Makefile Wed May 27 15:53:00 2009 -0300 +++ b/v4l/Makefile Thu May 28 10:05:04 2009 +0200 @@ -196,7 +196,7 @@ inst-m := $(obj-m) endif -v4l_modules := $(shell /sbin/lsmod|cut -d' ' -f1 ) $(patsubst %.ko,%,$(inst-m)) +v4l_modules := $(shell lsmod|cut -d' ' -f1 ) $(patsubst %.ko,%,$(inst-m)) ################################################# # locales seem to cause trouble sometimes.