From patchwork Sun May 10 14:16:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Eriksson X-Patchwork-Id: 997 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sun, 10 May 2009 14:16:37 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sun, 10 May 2009 11:19:41 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M39pV-0006UH-Ar; Sun, 10 May 2009 14:16:37 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752333AbZEJOQb (ORCPT + 1 other); Sun, 10 May 2009 10:16:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753577AbZEJOQa (ORCPT ); Sun, 10 May 2009 10:16:30 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:55760 "EHLO ch-smtp02.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbZEJOQ3 (ORCPT ); Sun, 10 May 2009 10:16:29 -0400 Received: from c83-252-236-9.bredband.comhem.se ([83.252.236.9]:58192 helo=tippex.mynet.homeunix.org) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.69) (envelope-from ) id 1M39pF-0002Ey-8b; Sun, 10 May 2009 16:16:28 +0200 Received: from tippex.mynet.homeunix.org (localhost [127.0.0.1]) by tippex.mynet.homeunix.org (Postfix) with ESMTP id D4A9C2C416C; Sun, 10 May 2009 16:16:14 +0200 (CEST) X-Mailer: exmh version 2.7.2 04/02/2003 (gentoo 2.7.2) with nmh-1.3 To: Anders Eriksson cc: hermann pitton , linux-media@vger.kernel.org, video4linux-list@redhat.com, Hartmut Hackmann Subject: Re: saa7134/2.6.26 regression, noisy output In-reply-to: <20090507130055.E49D32C4165@tippex.mynet.homeunix.org> References: <20090503075609.0A73B2C4152@tippex.mynet.homeunix.org> <1241389925.4912.32.camel@pc07.localdom.local> <20090504091049.D931B2C4147@tippex.mynet.homeunix.org> <1241438755.3759.100.camel@pc07.localdom.local> <20090504195201.6ECF52C415B@tippex.mynet.homeunix.org> <1241565988.16938.15.camel@pc07.localdom.local> <20090507130055.E49D32C4165@tippex.mynet.homeunix.org> Comments: In-reply-to Anders Eriksson message dated "Thu, 07 May 2009 15:00:55 +0200." Mime-Version: 1.0 Date: Sun, 10 May 2009 16:16:14 +0200 From: Anders Eriksson Message-Id: <20090510141614.D4A9C2C416C@tippex.mynet.homeunix.org> X-Originating-IP: 83.252.236.9 X-Scan-Result: No virus found in message 1M39pF-0002Ey-8b. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1M39pF-0002Ey-8b 0247c59535bc6a25e82f147d09072400 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org An update: >hermann-pitton@arcor.de said: >> hmm, the idea eventually was, to download these two snapshots, or make the >> last few changes manually on the first and try on 2.6.25. >> >> Then we might know, if the problem is already visible within Hartmut's latest >> fix attempts or even more and other stuff is involved. I wrote: >I see. I'll dig myself into hand applying those patches. It seems quite some >stuff changed between 2.6.25 and what those patches assumes. Let's see what I >dig up. Dragging the following patch along, .. I could actually bisect my way to the offending commit. And of course, it's the one you suspected: git 7bff4b4d3ad2b9ff42b4087f409076035af1d165. I'm right now applying that commit piece by piece, to isolate the offending change (Some changes are just rearrangements, others may change the way hw is touched). I'll keep you posted. -Anders --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 6fde042..938bdf5 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -5249,7 +5249,7 @@ static int saa7134_tda8290_callback(struct saa7134_dev *dev, int saa7134_tuner_callback(void *priv, int command, int arg) { struct i2c_algo_bit_data *i2c_algo = priv; - struct saa7134_dev *dev = i2c_algo->data; + struct saa7134_dev *dev = priv; switch (dev->tuner_type) { case TUNER_PHILIPS_TDA8290: