From patchwork Mon May 4 13:13:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 980 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 04 May 2009 13:16:14 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Mon, 04 May 2009 11:32:22 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M0y1m-0007qM-Dm; Mon, 04 May 2009 13:16:14 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755768AbZEDNPz (ORCPT + 1 other); Mon, 4 May 2009 09:15:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755639AbZEDNPz (ORCPT ); Mon, 4 May 2009 09:15:55 -0400 Received: from cmpxchg.org ([85.214.51.133]:52879 "EHLO cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754789AbZEDNPy (ORCPT ); Mon, 4 May 2009 09:15:54 -0400 Date: Mon, 4 May 2009 15:13:59 +0200 From: Johannes Weiner To: Christoph Hellwig Cc: Andrew Morton , Magnus Damm , linux-media@vger.kernel.org, Hans Verkuil , Paul Mundt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [patch 3/3 v2] mm: introduce follow_pfn() Message-ID: <20090504131359.GA17887@cmpxchg.org> References: <20090501181449.GA8912@cmpxchg.org> <1241430874-12667-3-git-send-email-hannes@cmpxchg.org> <20090504110841.GA19646@infradead.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090504110841.GA19646@infradead.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Analoguous to follow_phys(), add a helper that looks up the PFN at a user virtual address in an IO mapping or a raw PFN mapping. Signed-off-by: Johannes Weiner --- include/linux/mm.h | 2 ++ mm/memory.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 0 deletions(-) On Mon, May 04, 2009 at 07:08:41AM -0400, Christoph Hellwig wrote: > On Mon, May 04, 2009 at 11:54:34AM +0200, Johannes Weiner wrote: > > Analoguous to follow_phys(), add a helper that looks up the PFN > > instead. It also only allows IO mappings or PFN mappings. > > A kerneldoc describing what it does and the limitations would be > extremly helpful. Agreed. How is this? diff --git a/include/linux/mm.h b/include/linux/mm.h index bff1f0d..1cca8b6 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -794,6 +794,8 @@ int copy_page_range(struct mm_struct *dst, struct mm_struct *src, struct vm_area_struct *vma); void unmap_mapping_range(struct address_space *mapping, loff_t const holebegin, loff_t const holelen, int even_cows); +int follow_pfn(struct vm_area_struct *vma, unsigned long address, + unsigned long *pfn); int follow_phys(struct vm_area_struct *vma, unsigned long address, unsigned int flags, unsigned long *prot, resource_size_t *phys); int generic_access_phys(struct vm_area_struct *vma, unsigned long addr, diff --git a/mm/memory.c b/mm/memory.c index c047950..f86aee1 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3046,6 +3046,35 @@ out: return -EINVAL; } +/** + * follow_pfn - look up PFN at a user virtual address + * @vma: memory mapping + * @address: user virtual address + * @pfn: location to store found PFN + * + * Only IO mappings and raw PFN mappings are allowed. + * + * Returns zero and the pfn at @pfn on success, -ve otherwise. + */ +int follow_pfn(struct vm_area_struct *vma, unsigned long address, + unsigned long *pfn) +{ + int ret = -EINVAL; + spinlock_t *ptl; + pte_t *ptep; + + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) + return ret; + + ret = follow_pte(vma->vm_mm, address, &ptep, &ptl); + if (ret) + return ret; + *pfn = pte_pfn(*ptep); + pte_unmap_unlock(ptep, ptl); + return 0; +} +EXPORT_SYMBOL(follow_pfn); + #ifdef CONFIG_HAVE_IOREMAP_PROT int follow_phys(struct vm_area_struct *vma, unsigned long address, unsigned int flags,