From patchwork Mon Apr 27 09:29:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitri Belimov X-Patchwork-Id: 793 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 27 Apr 2009 23:29:08 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LyaG3-0003Kt-Oe; Mon, 27 Apr 2009 23:29:08 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbZD0X3F (ORCPT + 1 other); Mon, 27 Apr 2009 19:29:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753851AbZD0X3F (ORCPT ); Mon, 27 Apr 2009 19:29:05 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:55332 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639AbZD0X3E (ORCPT ); Mon, 27 Apr 2009 19:29:04 -0400 Received: by fxm2 with SMTP id 2so225490fxm.37 for ; Mon, 27 Apr 2009 16:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=mXqN+1tpwvkvMw9HN3D8Lbfl4e2z7tjja6WrQFlU4BE=; b=C2QQzU78xmx18QwJ7YFuDjaBSQfNSoXyWa+VymLzddmUIihtDUgpOA+BObbqPXa63f fH/TjQHLo53cPQtKmVCxl4b7ZXqIDpb+u3LM0AwVfJmQSD2IMcvvE70zB4+lNAsaw6qN la5017svEIfccHGHx+Dehnge8GXfUjimdKx/U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=t2TXW+lGU6NPIgFgNYquhc4TDthw1OiW5AQfMgb92tfYHo91SE2/49AuuvbxJ+d6Ct vPvmhY0oE4jzOjDqbuymqCYhXag1pHWjpzCn3KtJw9RcSOuq2WyI34FoLycfswuGDDFl fhT8N/08zjWs4WJia6Jqxsd+L3Cxc5ralPdI8= Received: by 10.103.213.19 with SMTP id p19mr3543827muq.9.1240874940834; Mon, 27 Apr 2009 16:29:00 -0700 (PDT) Received: from glory.loctelecom.ru (ns2.openhardware.ru [84.19.183.172]) by mx.google.com with ESMTPS id 23sm5456891mun.16.2009.04.27.16.28.57 (version=SSLv3 cipher=RC4-MD5); Mon, 27 Apr 2009 16:28:59 -0700 (PDT) Date: Mon, 27 Apr 2009 19:29:05 +1000 From: Dmitri Belimov To: Andy Walls Cc: video4linux-list@redhat.com, linux-media@vger.kernel.org Subject: Re: [PATCH] FM1216ME_MK3 some changes Message-ID: <20090427192905.3ad2b88c@glory.loctelecom.ru> In-Reply-To: <1240537394.3231.37.camel@palomino.walls.org> References: <20090422174848.1be88f61@glory.loctelecom.ru> <1240452534.3232.70.camel@palomino.walls.org> <20090423203618.4ac2bc6f@glory.loctelecom.ru> <1240537394.3231.37.camel@palomino.walls.org> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi All Step by step. This is patch for change only range of FM1216ME_MK3. Slow tunning is not a big problem. Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov With my best regards, Dmitry. > Hi Dmitri, > > Thank you for you responses. > > Just a few more comments... > > On Thu, 2009-04-23 at 20:36 +1000, Dmitri Belimov wrote: > > Hi Andy > > > > > Dmitri, > > > > > > > > > On Wed, 2009-04-22 at 17:48 +1000, Dmitri Belimov wrote: > > > > Hi All > > > > > > > > 1. Change middle band. In the end of the middle band the > > > > sensitivity of receiver not good. If we switch to higher band, > > > > sensitivity more better. Hardware trick. > > > > > > Several years a go your customers write some messages about bad > > quality of TV if frequency of TV is the end of band. It can be low > > band or middle. Our hardware engeneer make some tests with hardware > > TV generator and our TV tuners. > > > > If we set default frequency range for low and middle band, quality > > of TV signal on 159MHz and 442 MHz is bad. When we make our changes > > with moving end of bands the quality of TV much better. And our > > system programmer for OS Windows use changed bands for drivers. > > Customers be happy. > > OK. A properly run experiment wins over theory every time. :) > > > > > You can test it if in your placement available TV programm on > > 159MHz or 442MHz. This trick can be usefull for other tuners. > > If you look at tveeprom.c, a number of other tuners are using that > tuner definition: > > $ grep FM1216ME_MK3 tveeprom.c > { TUNER_PHILIPS_FM1216ME_MK3, "Philips FQ1216ME MK3"}, > { TUNER_PHILIPS_FM1216ME_MK3, "Philips FM1216 ME > MK3"}, { TUNER_PHILIPS_FM1216ME_MK3, "LG S001D MK3"}, > { TUNER_PHILIPS_FM1216ME_MK3, "LG S701D MK3"}, > { TUNER_PHILIPS_FM1216ME_MK3, "Philips FQ1216LME > MK3"}, { TUNER_PHILIPS_FM1216ME_MK3, "TCL MFPE05 2"}, > { TUNER_PHILIPS_FM1216ME_MK3, "TCL MPE05-2"}, > { TUNER_PHILIPS_FM1216ME_MK3, "Philips FM1216ME MK5"}, > > If your change makes things bad for the other tuners, we'll probably > have to create an alternate entry for the other tuners instead of > using the FM1216ME_MK3 defintion. I suspect most of them are clones > of the FM1216ME MK3 however, so it probably won't matter. > > > > > 3. Set charge pump bit > > > > > > This will improve the time to initially tune to a frequency, but > > > will likely add some noise as the PLL continues to maintain lock > > > on the signal. If there is no way to turn off the CP after the > > > lock bit is set in the tuner, it's probably better to leave it > > > off for lower noise and just live with slower tuning. > > > > We discuss with our windows system programmer about it. He sad that > > in analog TV mode noise from PLL don't give any problem. > > I would be concerned about phase noise affecting the colors or any FM > sound carriers. If the noise isn't noticably affecting colors to the > human eye (do color bars look OK?), or sound to the human ear, then > OK. > > > > But in digital TV mode > > noise from PLL decreased BER. > > I thought the FM1216ME MK3 was an analog only tuner. I guess I don't > know DVB-T or cable in Europe well enough. > > > > > Leaving the CP bit set should be especially noticable ad FM noise > > > when set to tune to FM radio stations. From the FM1236ME_MK3 > > > datasheet: "It is recommended to set CP=0 in the FM mode at all > > > times." But the VHF low band control byte is also used when > > > setting FM radio (AFAICT with a quick look at the code.) > > > > Yes. You are right. We can swith CP off in FM mode. > > OK. Thank you. > > > With my best regards, Dmitry. > > > Regards, > Andy > > > Acked-by: Hermann Pitton diff -r b40d628f830d linux/drivers/media/common/tuners/tuner-types.c --- a/linux/drivers/media/common/tuners/tuner-types.c Fri Apr 24 01:46:41 2009 -0300 +++ b/linux/drivers/media/common/tuners/tuner-types.c Tue Apr 28 03:35:42 2009 +1000 @@ -558,8 +558,8 @@ static struct tuner_range tuner_fm1216me_mk3_pal_ranges[] = { { 16 * 158.00 /*MHz*/, 0x8e, 0x01, }, - { 16 * 442.00 /*MHz*/, 0x8e, 0x02, }, - { 16 * 999.99 , 0x8e, 0x04, }, + { 16 * 441.00 /*MHz*/, 0x8e, 0x02, }, + { 16 * 864.00 , 0x8e, 0x04, }, }; static struct tuner_params tuner_fm1216me_mk3_params[] = { Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov