From patchwork Wed Jul 15 04:24:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sowjanya Komatineni X-Patchwork-Id: 65501 X-Patchwork-Delegate: sakari.ailus@iki.fi Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1jvYsS-00Fc3E-7s; Wed, 15 Jul 2020 04:18:43 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725811AbgGOEX0 (ORCPT + 1 other); Wed, 15 Jul 2020 00:23:26 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:9849 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbgGOEXZ (ORCPT ); Wed, 15 Jul 2020 00:23:25 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 14 Jul 2020 21:21:31 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 14 Jul 2020 21:23:25 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 14 Jul 2020 21:23:25 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 15 Jul 2020 04:23:24 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 15 Jul 2020 04:23:24 +0000 Received: from skomatineni-linux.nvidia.com (Not Verified[10.2.160.169]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Tue, 14 Jul 2020 21:23:24 -0700 From: Sowjanya Komatineni To: , , , , , , , , , CC: , , Subject: [PATCH v1 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Date: Tue, 14 Jul 2020 21:24:54 -0700 Message-ID: <1594787096-26685-1-git-send-email-skomatineni@nvidia.com> X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594786891; bh=Oj/AaLFlln62HXD5floz+5zGqce5eprSTQuw0CPgGb0=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=oJi1ZtVZOZW1uVlVS5KJK2ApZt0FFCjXp9zkne5V8+SQEI6jjwjLfi5nLcBCR3GC1 4bAB52lCuJ2toVlX+xh0OoYyyv0NdjYcwyJpdOF0HduarvaDZmVldplk3qVZNkRxuV ZeFJqcEA1uFyeSKXXIhz+355QmtU0XTsBqAmVpH74HkPyDaXLH6tLCSyi8sfg0vjaw OrEow7Y70WEZU2v4BowK+mV+1Ua/ewmX2JWvYPh9MhhiRD+bVRqlleJfJuaUucwXG9 Ou2MANlirNGeNvPeB1plmW8Po2GuH82cdzut9wD9Svm53LQlFLxTz5uNWe/MGWo6hn aCDY9I4tO3ijg== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Current driver sets Y_OUT_SIZE to crop height + 8 and seeing long frame errors on the receiver size as expected height on reciever is crop height. As per Sony IMX274 Y_OUT_SIZE should be the height of effective image output from the sensor which are the actual total lines sent over MIPI CSI to receiver. So, Y_OUT_SIZE should be same as crop height and this patch fixes it. Signed-off-by: Sowjanya Komatineni --- drivers/media/i2c/imx274.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c index e6aa9f3..55869ff 100644 --- a/drivers/media/i2c/imx274.c +++ b/drivers/media/i2c/imx274.c @@ -1163,7 +1163,7 @@ static int imx274_apply_trimming(struct stimx274 *imx274) (-imx274->crop.top / 2) : (imx274->crop.top / 2); v_cut = (IMX274_MAX_HEIGHT - imx274->crop.height) / 2; write_v_size = imx274->crop.height + 22; - y_out_size = imx274->crop.height + 14; + y_out_size = imx274->crop.height; err = imx274_write_mbreg(imx274, IMX274_HMAX_REG_LSB, hmax, 2); if (!err)