Message ID | 1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1iUQ2o-0006FK-Mk; Tue, 12 Nov 2019 06:52:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfKLGwd (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 12 Nov 2019 01:52:33 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:8874 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727257AbfKLGwc (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 12 Nov 2019 01:52:32 -0500 X-UUID: 8bb912ab5b2a4142804270d7b23227c0-20191112 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=sqinwE6urNgoomSdVqJFpcp+5OZZKqz/VmNqkBZzAjU=; b=UEQjcUsQnOdD0+MP7YM3z2MuvZIeuykYL96DmcFVuGjtiuFy/kcyT9jqPG7NJY+w7EtO5dyzOhOG6DketrTLQSdJU+/DiYfnmI+TdZemXEvNxN3NoEka5hKKdqrhMIbznjXcIqxvoKtVJx/9aTsxtBhXvCemWVrTvGivsseZ7vA=; X-UUID: 8bb912ab5b2a4142804270d7b23227c0-20191112 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from <chunfeng.yun@mediatek.com>) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 628214827; Tue, 12 Nov 2019 14:52:27 +0800 Received: from mtkmbs05dr.mediatek.inc (172.21.101.97) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 12 Nov 2019 14:52:25 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05dr.mediatek.inc (172.21.101.97) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 12 Nov 2019 14:52:25 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 12 Nov 2019 14:52:23 +0800 From: Chunfeng Yun <chunfeng.yun@mediatek.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Felipe Balbi <balbi@kernel.org> CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, Peter Chen <Peter.Chen@nxp.com>, "Minas Harutyunyan" <hminas@synopsys.com>, Cristian Birsan <cristian.birsan@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Kevin Cernekee <cernekee@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, <bcm-kernel-feedback-list@broadcom.com>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, "Bin Liu" <b-liu@ti.com>, Matthias Brugger <matthias.bgg@gmail.com>, Stephen Boyd <swboyd@chromium.org>, Chunfeng Yun <chunfeng.yun@mediatek.com>, "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>, Colin Ian King <colin.king@canonical.com>, Biju Das <biju.das@bp.renesas.com>, "Fabrizio Castro" <fabrizio.castro@bp.renesas.com>, "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Yangtao Li <tiny.windzz@gmail.com>, <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org> Subject: [PATCH v2 12/13] usb: gadget: udc: gr_udc: create debugfs directory under usb root Date: Tue, 12 Nov 2019 14:51:58 +0800 Message-ID: <1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Series |
[v2,01/13] media: uvcvideo: drop error check of debugfs_create_dir()
|
|
Commit Message
Chunfeng Yun
Nov. 12, 2019, 6:51 a.m. UTC
Now the USB gadget subsystem can use the USB debugfs root directory,
so move it's directory from the root of the debugfs filesystem into
the root of usb
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2:
1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root
---
drivers/usb/gadget/udc/gr_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Nov 12, 2019 at 02:51:58PM +0800, Chunfeng Yun wrote: > Now the USB gadget subsystem can use the USB debugfs root directory, > so move it's directory from the root of the debugfs filesystem into > the root of usb > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: > 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root > --- > drivers/usb/gadget/udc/gr_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c > index 7a0e9a58c2d8..5faa09a6c770 100644 > --- a/drivers/usb/gadget/udc/gr_udc.c > +++ b/drivers/usb/gadget/udc/gr_udc.c > @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev) > { > const char *name = "gr_udc_state"; > > - dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL); > + dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); > debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); > } > This breaks the build: drivers/usb/gadget/udc/gr_udc.c: In function ‘gr_dfs_create’: drivers/usb/gadget/udc/gr_udc.c:211:57: error: ‘usb_debug_root’ undeclared (first use in this function) 211 | dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); | ^~~~~~~~~~~~~~ drivers/usb/gadget/udc/gr_udc.c:211:57: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:265: drivers/usb/gadget/udc/gr_udc.o] Error 1 so I've dropped it from the patch series. Please fix up and resend. And of course, always test-build your patches before you send them out... greg k-h
On Thu, 2019-11-14 at 11:21 +0800, Greg Kroah-Hartman wrote: > On Tue, Nov 12, 2019 at 02:51:58PM +0800, Chunfeng Yun wrote: > > Now the USB gadget subsystem can use the USB debugfs root directory, > > so move it's directory from the root of the debugfs filesystem into > > the root of usb > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > v2: > > 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root > > --- > > drivers/usb/gadget/udc/gr_udc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c > > index 7a0e9a58c2d8..5faa09a6c770 100644 > > --- a/drivers/usb/gadget/udc/gr_udc.c > > +++ b/drivers/usb/gadget/udc/gr_udc.c > > @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev) > > { > > const char *name = "gr_udc_state"; > > > > - dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL); > > + dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); > > debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); > > } > > > > This breaks the build: > drivers/usb/gadget/udc/gr_udc.c: In function ‘gr_dfs_create’: > drivers/usb/gadget/udc/gr_udc.c:211:57: error: ‘usb_debug_root’ undeclared (first use in this function) > 211 | dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); > | ^~~~~~~~~~~~~~ > drivers/usb/gadget/udc/gr_udc.c:211:57: note: each undeclared identifier is reported only once for each function it appears in > make[4]: *** [scripts/Makefile.build:265: drivers/usb/gadget/udc/gr_udc.o] Error 1 > > so I've dropped it from the patch series. > > Please fix up and resend. Ok > > And of course, always test-build your patches before you send them > out... Sorry, will do it > > greg k-h
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index 7a0e9a58c2d8..5faa09a6c770 100644 --- a/drivers/usb/gadget/udc/gr_udc.c +++ b/drivers/usb/gadget/udc/gr_udc.c @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev) { const char *name = "gr_udc_state"; - dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL); + dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); }