From patchwork Tue Nov 6 10:16:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 52792 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJyOi-0007h7-Qu; Tue, 06 Nov 2018 10:15:49 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387776AbeKFTkR (ORCPT + 1 other); Tue, 6 Nov 2018 14:40:17 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36047 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387480AbeKFTkQ (ORCPT ); Tue, 6 Nov 2018 14:40:16 -0500 Received: by mail-qt1-f194.google.com with SMTP id u34-v6so1918762qth.3 for ; Tue, 06 Nov 2018 02:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OIc6QTHcHgsHNHKI/MaHnphn7cUAfw1n2uh31oAL0/A=; b=DpBBuCJcZAwyNB4/DNCrD0W7vTsBA8fp3Q5CQ83sBh2GubRx9woKi7yyZfyzFai4mT DxApYoTqLP+wp1UOD/s6qa522D77HNKKeb4Pyo7qx9RyZUJqe9D7MXkjMHBSHPtIPnfa tNH+C/QwS0OqgDJRtxT49NJjJotBuPPQ+eGTEhWO0yyxBw4P5p5CE/1YlVneKQ9UH+aX 6j5YP/f8rhSiux10JUjUV7mxIH0dhr6X+zT6b8uU/pou4H4Z11lVi5hsYZ26C+gbETj4 gacbpohJrR0Af3V4Enfx6kug3XqZ32PVzOW5JEXnYHONdMKyM74B6dN5DdXugAKeGRmW nxXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OIc6QTHcHgsHNHKI/MaHnphn7cUAfw1n2uh31oAL0/A=; b=Zj+DYskuXPMrzkfmGPTX7gOgak8BTpD1pB/piqL7TkiHxyZauReFRPW4oi00hZDlWF mv4sn6EKHtozraDV6McwpEyIrP+ZOFMFlokNfQNhhmKp0uIzZyQtlgIWrGreUZ3IOQmH 8Nw1O9F6u+EV5HoQzXZHaz0H0/VCcyXRf5FMn2XxMrVDKc5Wi7SitUKJBs36BenX2mvB RNvGbZ/csV5Lqf/+dHbcurH9hikJxbT4GIy5dJV2vtUX94LOnChgh3vukkNWqkAluJ+d wvD87/BrwIBYrULy/Yub5RlnZVUCCccwMSkfF7EZ5v3Q35lAguWS9UWdxpxjlL5KP34d nbdQ== X-Gm-Message-State: AGRZ1gLvXhLW2I9J+CMrZ8BX4SXIRiMrA6DUBGtyYJOWy6sLLGDqAiDi lgszYduOrxDYNF1N2nXhVKY= X-Google-Smtp-Source: AJdET5eS/U8A/S19JtNhmNXzbreBYfLXj4HdRG/b7ZjeK+fDl1H2KNJ3T+NxA032IxoB7YiEzNnfTQ== X-Received: by 2002:a0c:d232:: with SMTP id m47mr25853813qvh.43.1541499346436; Tue, 06 Nov 2018 02:15:46 -0800 (PST) Received: from localhost.localdomain ([201.82.144.36]) by smtp.gmail.com with ESMTPSA id s46sm5000062qtc.63.2018.11.06.02.15.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Nov 2018 02:15:45 -0800 (PST) From: Fabio Estevam To: p.zabel@pengutronix.de Cc: mchehab@kernel.org, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH v3 1/3] media: imx-pxp: Check the return value from clk_prepare_enable() Date: Tue, 6 Nov 2018 08:16:03 -0200 Message-Id: <1541499365-10069-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - None drivers/media/platform/imx-pxp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c index b76cd0e..27780f1 100644 --- a/drivers/media/platform/imx-pxp.c +++ b/drivers/media/platform/imx-pxp.c @@ -1666,7 +1666,10 @@ static int pxp_probe(struct platform_device *pdev) return ret; } - clk_prepare_enable(dev->clk); + ret = clk_prepare_enable(dev->clk); + if (ret < 0) + return ret; + pxp_soft_reset(dev); spin_lock_init(&dev->irqlock);