From patchwork Mon Nov 5 20:45:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 52785 Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJlkB-0003ff-4t; Mon, 05 Nov 2018 20:45:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730324AbeKFGGe (ORCPT + 1 other); Tue, 6 Nov 2018 01:06:34 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42802 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbeKFGGe (ORCPT ); Tue, 6 Nov 2018 01:06:34 -0500 Received: by mail-qt1-f193.google.com with SMTP id z20-v6so193170qti.9 for ; Mon, 05 Nov 2018 12:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=snYpUzaN7gsQsYEFLrXEZxhrhmYrBqVktQ9ekgI3g0o=; b=ApflcW/eTDZOWw3rgRzIyGrOSjcwguFPOs9mAU0SMGWZ41eNGEkNL4TcOi1lvxLJWp NaNPJdu8AGtwbHY6M3udLkYoBpABoOiD89e5P4HzFO+kZa8f6wfUkguQtgf3+Zaa96qA 7eGHgnatrQkz2bLvLabihWXhuVQcvW07As8JWehhBZ/LR/Rf7QBx2JBd2PSAK9HwuwvO HtHuWAbdXhYjqt4tuxSSO4oOhW7YGm7/efoC9Uxq9NAyOoneOHwPEahVGwkJxS+PQFFb bm2CV9a07p+hmGYC87MwFSsvT+MPUU0H5x2EYRb7rA4EqYsZEmOkYAVM4lQMQwlXbLqS WteA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=snYpUzaN7gsQsYEFLrXEZxhrhmYrBqVktQ9ekgI3g0o=; b=IEKQuRyODZMReSKA1ZJ6OVJVhQxQZptcFrclJp1OBH5CTOnCGbPo8U+FyquRSWJzGy LGB/byTMqwBvBE5ytWV84cj6YKSubpmKmZ0sJSI6TZCjs9ZHzz6OMgnupdVUBgJKZa9F 3kNO/YA9P8vX2WuIJ3AZmhkcbBrfxIdUhv8whBSzAipPr5QkdESuvmtbxwCCVQtpgaOl 1JSrqFs68H3KLwJBLMoIyVmJpTtl7PTySJW7MvGM9jNiwKDYdouGVUfqOuNaomPTY4p2 4C31gjlSoHxs4cUez9taGVmBS/9KePwSaimp0Zi5YYIPrgJqndos0WTApsO/SufYwlj5 4I5w== X-Gm-Message-State: AGRZ1gJ6mr1RbSYbS+a1TbtiPlXn7wrWbOUgbtJbCWK1asBIU0FYfLBK HizvZQaT0IQEvLh6wx0892A= X-Google-Smtp-Source: AJdET5dIoxl1bkxRoQ+EGQwSDFlkoXGMQFOwn4n9vk7XLy2uKvqr05PIvfPmOwdLGQrUReNxF+HRBg== X-Received: by 2002:a0c:aa84:: with SMTP id f4mr22927480qvb.243.1541450703708; Mon, 05 Nov 2018 12:45:03 -0800 (PST) Received: from localhost.localdomain ([201.82.144.36]) by smtp.gmail.com with ESMTPSA id 5sm10167968qkv.93.2018.11.05.12.45.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Nov 2018 12:45:03 -0800 (PST) From: Fabio Estevam To: p.zabel@pengutronix.de Cc: mchehab@kernel.org, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH v2 3/3] media: imx-pxp: Improve pxp_soft_reset() error message Date: Mon, 5 Nov 2018 18:45:16 -0200 Message-Id: <1541450716-25523-3-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541450716-25523-1-git-send-email-festevam@gmail.com> References: <1541450716-25523-1-git-send-email-festevam@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Improve the pxp_soft_reset() error message by moving it to the caller function, associating it with a proper device and also by displaying the error code. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v1: - Newly introduced in this version drivers/media/platform/imx-pxp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c index b3700b8..1b765c9 100644 --- a/drivers/media/platform/imx-pxp.c +++ b/drivers/media/platform/imx-pxp.c @@ -1619,10 +1619,8 @@ static int pxp_soft_reset(struct pxp_dev *dev) ret = readl_poll_timeout(dev->mmio + HW_PXP_CTRL, val, val & BM_PXP_CTRL_CLKGATE, 0, 100); - if (ret < 0) { - pr_err("PXP reset timeout\n"); + if (ret < 0) return ret; - } writel(BM_PXP_CTRL_SFTRST, dev->mmio + HW_PXP_CTRL_CLR); writel(BM_PXP_CTRL_CLKGATE, dev->mmio + HW_PXP_CTRL_CLR); @@ -1675,8 +1673,10 @@ static int pxp_probe(struct platform_device *pdev) return ret; ret = pxp_soft_reset(dev); - if (ret < 0) + if (ret < 0) { + dev_err(&pdev->dev, "PXP reset timeout: %d\n", ret); return ret; + } spin_lock_init(&dev->irqlock);