From patchwork Wed May 30 10:55:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 50016 Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNynU-00047H-0U; Wed, 30 May 2018 10:57:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbeE3K5O (ORCPT + 1 other); Wed, 30 May 2018 06:57:14 -0400 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:52440 "EHLO mail.osadl.at" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751503AbeE3K5M (ORCPT ); Wed, 30 May 2018 06:57:12 -0400 Received: by mail.osadl.at (Postfix, from userid 1001) id A482E5C05BA; Wed, 30 May 2018 10:55:57 +0000 (UTC) From: Nicholas Mc Guire To: Hans Verkuil Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] media: adv7604: simplify of_node_put() Date: Wed, 30 May 2018 10:55:16 +0000 Message-Id: <1527677716-30352-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Nicholas Mc Guire As the of_node_put() is unconditional here there is no need to have it twice. Signed-off-by: Nicholas Mc Guire --- Problem located by experimental coccinelle script Not sure if such a change makes this much more readable - it is a trivial simplification of the code though. Pleas let me know if such micro refactoring makes sense or not. Patch was compile tested with: x86_64_defconfig + GPIOLIB=y, Multimedia support=y, CONFIG_MEDIA_DIGITAL_TV_SUPPORT=y, CONFIG_MEDIA_CAMERA_SUPPORT=y CONFIG_VIDEO_V4L2_SUBDEV_API=y, CONFIG_VIDEO_ADV7604=y Patch is against 4.17-rc5 (localversion-next is -next-20180529) drivers/media/i2c/adv7604.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index cac2081..cc8eac3 100644 --- a/drivers/media/i2c/adv7604.c +++ b/drivers/media/i2c/adv7604.c @@ -3108,12 +3108,9 @@ static int adv76xx_parse_dt(struct adv76xx_state *state) return -EINVAL; ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(endpoint), &bus_cfg); - if (ret) { - of_node_put(endpoint); - return ret; - } - of_node_put(endpoint); + if (ret) + return ret; if (!of_property_read_u32(np, "default-input", &v)) state->pdata.default_input = v;