From patchwork Mon Mar 19 05:32:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ji-Hun Kim X-Patchwork-Id: 47994 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exnQW-00060c-Pd; Mon, 19 Mar 2018 05:33:45 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996AbeCSFdU (ORCPT + 1 other); Mon, 19 Mar 2018 01:33:20 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:12510 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbeCSFdS (ORCPT ); Mon, 19 Mar 2018 01:33:18 -0400 Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20180319053316epoutp03960b83dba2d41b9f7b6094b072196c14~dO27CxJqA1719117191epoutp03Y; Mon, 19 Mar 2018 05:33:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180319053316epoutp03960b83dba2d41b9f7b6094b072196c14~dO27CxJqA1719117191epoutp03Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1521437596; bh=rf69jUDJ/xP9mjsFfqYX8+R9Q8ZbXcXpuPtNNlJR4Xw=; h=From:To:Cc:Subject:Date:References:From; b=Q16TgOaQNoEs27adt4SvgSgwEDPczNcyHoBXrg0PKdgvtQ6Rg0JAlsbsIkvBcFotj Ozb2tmBjPKB6Zd+mlKc7QtW1AJWCXu3oJzGC8uSpT/bccfUdzNiGzBjRehbum0na3O Z7DPul+wfNZyKDVaRug4eLPjDoH7+v4VGDswcywE= Received: from epsmges2p1.samsung.com (unknown [182.195.40.94]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20180319053315epcas1p1b232c5edb5646b24ca8927b9fab871cd~dO26xVaGv1846318463epcas1p1Q; Mon, 19 Mar 2018 05:33:15 +0000 (GMT) Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id 4E.18.04131.B9B4FAA5; Mon, 19 Mar 2018 14:33:15 +0900 (KST) Received: from epsmgms2p2new.samsung.com (unknown [182.195.42.143]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20180319053315epcas2p3c61bd9a1bec8d67cde77765842a3205c~dO26cqW_b0183801838epcas2p3j; Mon, 19 Mar 2018 05:33:15 +0000 (GMT) X-AuditID: b6c32a45-403ff70000001023-1b-5aaf4b9bfebe Received: from epmmp1.local.host ( [203.254.227.16]) by epsmgms2p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 11.31.03890.B9B4FAA5; Mon, 19 Mar 2018 14:33:15 +0900 (KST) Received: from localhost.localdomain ([10.253.107.61]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P5T00MIGOR86L80@mmp1.samsung.com>; Mon, 19 Mar 2018 14:33:15 +0900 (KST) From: Ji-Hun Kim To: mchehab@kernel.org, dan.carpenter@oracle.com Cc: gregkh@linuxfoundation.org, arvind.yadav.cs@gmail.com, ji_hun.kim@samsung.com, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] staging: media: davinci_vpfe: add error handling on kmalloc failure Date: Mon, 19 Mar 2018 14:32:57 +0900 Message-id: <1521437577-8168-1-git-send-email-ji_hun.kim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsWy7bCmhe5s7/VRBtfmaVlc613IbPH633QW iz1nfrFbNC9ez2bRf3o7o8XWW9IWl3fNYbPo2bCV1WLZpj9MDpwe9/YdZvHYOesuu8emVZ1s HvvnrmH3+Pj0FotH35ZVjB6fN8kFsEel2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpa WpgrKeQl5qbaKrn4BOi6ZeYAXaakUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVWKNjQ00jM0 MNczMjLSMzGPtTIyBSpJSM34dOAIS8FVrooz/+cyNTDe5+hi5OSQEDCRWLJ8MjuILSSwg1Hi VLNUFyMXkP2dUeLlnHPMMEW/7/1jhkjsZpRYN+sxE4Tzg1Hi4eIDbCBVbAKaEhu7rzF2MXJw iAgYSPTOjQapYRY4zyjRc+wRM0hcWCBSYutNN5ByFgFViYnv+8AW8Aq4SuxrfswKsUxO4uSx yawgvRICU9gkru+cxQiRcJE4NWEjO4QtLPHq+BYoW1ri2aqNUDXVEguu7GCBsGskbv5fygRh G0v09lwAW8YswCfRcfgvO8g9EgK8Eh1tQhAlHhJX1x+GanWUmLN4HRskVGIlNjy5zzSBUXIB I8MqRrHUguLc9NRiowJDveLE3OLSvHS95PzcTYzgpKLluoNxxjmfQ4wCHIxKPLwOR9dFCbEm lhVX5h5ilOBgVhLhfXoFKMSbklhZlVqUH19UmpNafIjRFBgcE5mlRJPzgQkvryTe0MTSwMTM zNDcyNTAXEmcty3AJUpIID2xJDU7NbUgtQimj4mDU6qBcZVi9Ybd7/9YVTxW/Hmneo/kPDXj RWU3xGp2f0m5MUVZW5BHRv1b0TQzLj+uCNEPS5wrc7y0rtzN/CG5u1hNYjrDHR7GxNhF2slH yw7kSD3a73HJ13Ari3eAQPP7hkmx/yUML52VbWy+c27Cq4PK2hvLJqwIPp075bJMxyShz/tO dcZLucrcVGIpzkg01GIuKk4EAFhnXxtAAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnluLIzCtJLcpLzFFi42I5/e+xgO5s7/VRBs0fBS2u9S5ktnj9bzqL xZ4zv9gtmhevZ7PoP72d0WLrLWmLy7vmsFn0bNjKarFs0x8mB06Pe/sOs3jsnHWX3WPTqk42 j/1z17B7fHx6i8Wjb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mj4dOMJScJWr4sz/uUwNjPc5 uhg5OSQETCR+3/vH3MXIxSEksJNRYvGynWwQzg9GiVuPJrGDVLEJaEps7L7G2MXIwSEiYCDR OzcapIZZ4DyjxN3Zx1lAaoQFIiXuzN4HZrMIqEpMfN/HDGLzCrhK7Gt+zAqxTU7i5LHJrBMY uRYwMqxilEwtKM5Nzy02KjDKSy3XK07MLS7NS9dLzs/dxAgMnm2Htfp3MD5eEn+IUYCDUYmH 1+Houigh1sSy4srcQ4wSHMxKIrxPrwCFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8/LnH4sUEkhP LEnNTk0tSC2CyTJxcEo1MG5+ZBo7t9wzyGT29Z5aZy4dpj37+6yd7ydyqx0Q/7y6fHaYWW3G FcnVGQ+sLA6t+V2rpvjlxYsX+j2pCw/2zO3dEjT/zsHKLRvTv1006KiMWPSw5tL5/NJ1f0oL An0OmXjP/PDGJ3HrPc42hWWW+r+Lr5xsuj/9kl9/2fm73Cr3pJe66Z39IKLEUpyRaKjFXFSc CABMTBueGgIAAA== X-CMS-MailID: 20180319053315epcas2p3c61bd9a1bec8d67cde77765842a3205c X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180319053315epcas2p3c61bd9a1bec8d67cde77765842a3205c X-RootMTR: 20180319053315epcas2p3c61bd9a1bec8d67cde77765842a3205c References: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is no failure checking on the param value which will be allocated memory by kmalloc. Add a null pointer checking statement. Then goto error: and return -ENOMEM error code when kmalloc is failed. Signed-off-by: Ji-Hun Kim --- Changes since v1: - Return with -ENOMEM directly, instead of goto error: then return. drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 6a3434c..ffcd86d 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1280,6 +1280,9 @@ static int ipipe_s_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) params = kmalloc(sizeof(struct ipipe_module_params), GFP_KERNEL); + if (!params) + return -ENOMEM; + to = (void *)params + module_if->param_offset; size = module_if->param_size; @@ -1323,6 +1326,9 @@ static int ipipe_g_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) params = kmalloc(sizeof(struct ipipe_module_params), GFP_KERNEL); + if (!params) + return -ENOMEM; + from = (void *)params + module_if->param_offset; size = module_if->param_size;