From patchwork Mon Jan 8 12:40:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 46354 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYWfj-0003vx-BC; Mon, 08 Jan 2018 12:36:59 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757248AbeAHMf6 (ORCPT + 1 other); Mon, 8 Jan 2018 07:35:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3700 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757295AbeAHMfr (ORCPT ); Mon, 8 Jan 2018 07:35:47 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0B6EFBA464B2E; Mon, 8 Jan 2018 20:35:34 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 20:35:24 +0800 From: Xiongfeng Wang To: CC: , , , Subject: [PATCH] media: media-device: use strlcpy() instead of strncpy() Date: Mon, 8 Jan 2018 20:40:59 +0800 Message-ID: <1515415259-195067-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/media/media-device.c: In function 'media_device_get_topology': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the dest string is nul-terminated. Signed-off-by: Xiongfeng Wang Acked-by: Sakari Ailus --- drivers/media/media-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index e79f72b..f442444 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev, memset(&kentity, 0, sizeof(kentity)); kentity.id = entity->graph_obj.id; kentity.function = entity->function; - strncpy(kentity.name, entity->name, + strlcpy(kentity.name, entity->name, sizeof(kentity.name)); if (copy_to_user(uentity, &kentity, sizeof(kentity)))